Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: components/test_runner/web_test_proxy.h

Issue 1908183002: Use correct WebView from TestRunner methods called via testRunner bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@accessibility-controller-per-view
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_TEST_RUNNER_WEB_TEST_PROXY_H_ 5 #ifndef COMPONENTS_TEST_RUNNER_WEB_TEST_PROXY_H_
6 #define COMPONENTS_TEST_RUNNER_WEB_TEST_PROXY_H_ 6 #define COMPONENTS_TEST_RUNNER_WEB_TEST_PROXY_H_
7 7
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 26 matching lines...) Expand all
37 struct WebFileChooserParams; 37 struct WebFileChooserParams;
38 struct WebPoint; 38 struct WebPoint;
39 struct WebWindowFeatures; 39 struct WebWindowFeatures;
40 } 40 }
41 41
42 namespace test_runner { 42 namespace test_runner {
43 43
44 class AccessibilityController; 44 class AccessibilityController;
45 class EventSender; 45 class EventSender;
46 class TestInterfaces; 46 class TestInterfaces;
47 class TestRunnerForSpecificView;
47 class TextInputController; 48 class TextInputController;
48 class WebTestDelegate; 49 class WebTestDelegate;
49 class WebTestInterfaces; 50 class WebTestInterfaces;
50 51
51 // WebTestProxyBase is the "brain" of WebTestProxy in the sense that 52 // WebTestProxyBase is the "brain" of WebTestProxy in the sense that
52 // WebTestProxy does the bridge between RenderViewImpl and WebTestProxyBase and 53 // WebTestProxy does the bridge between RenderViewImpl and WebTestProxyBase and
53 // when it requires a behavior to be different from the usual, it will call 54 // when it requires a behavior to be different from the usual, it will call
54 // WebTestProxyBase that implements the expected behavior. 55 // WebTestProxyBase that implements the expected behavior.
55 // See WebTestProxy class comments for more information. 56 // See WebTestProxy class comments for more information.
56 class TEST_RUNNER_EXPORT WebTestProxyBase { 57 class TEST_RUNNER_EXPORT WebTestProxyBase {
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 106
106 private: 107 private:
107 TestInterfaces* test_interfaces_; 108 TestInterfaces* test_interfaces_;
108 WebTestDelegate* delegate_; 109 WebTestDelegate* delegate_;
109 blink::WebView* web_view_; 110 blink::WebView* web_view_;
110 blink::WebWidget* web_widget_; 111 blink::WebWidget* web_widget_;
111 scoped_ptr<WebViewTestClient> view_test_client_; 112 scoped_ptr<WebViewTestClient> view_test_client_;
112 scoped_ptr<AccessibilityController> accessibility_controller_; 113 scoped_ptr<AccessibilityController> accessibility_controller_;
113 scoped_ptr<EventSender> event_sender_; 114 scoped_ptr<EventSender> event_sender_;
114 scoped_ptr<TextInputController> text_input_controller_; 115 scoped_ptr<TextInputController> text_input_controller_;
116 scoped_ptr<TestRunnerForSpecificView> view_test_runner_;
115 117
116 DISALLOW_COPY_AND_ASSIGN(WebTestProxyBase); 118 DISALLOW_COPY_AND_ASSIGN(WebTestProxyBase);
117 }; 119 };
118 120
119 // WebTestProxy is used during LayoutTests and always instantiated, at time of 121 // WebTestProxy is used during LayoutTests and always instantiated, at time of
120 // writing with Base=RenderViewImpl. It does not directly inherit from it for 122 // writing with Base=RenderViewImpl. It does not directly inherit from it for
121 // layering purposes. 123 // layering purposes.
122 // The intent of that class is to wrap RenderViewImpl for tests purposes in 124 // The intent of that class is to wrap RenderViewImpl for tests purposes in
123 // order to reduce the amount of test specific code in the production code. 125 // order to reduce the amount of test specific code in the production code.
124 // WebTestProxy is only doing the glue between RenderViewImpl and 126 // WebTestProxy is only doing the glue between RenderViewImpl and
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 228
227 private: 229 private:
228 virtual ~WebTestProxy() {} 230 virtual ~WebTestProxy() {}
229 231
230 DISALLOW_COPY_AND_ASSIGN(WebTestProxy); 232 DISALLOW_COPY_AND_ASSIGN(WebTestProxy);
231 }; 233 };
232 234
233 } // namespace test_runner 235 } // namespace test_runner
234 236
235 #endif // COMPONENTS_TEST_RUNNER_WEB_TEST_PROXY_H_ 237 #endif // COMPONENTS_TEST_RUNNER_WEB_TEST_PROXY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698