allow imagefilter to manage CTM decomposition

allow imagefilter to manage CTM decomposition

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908173006

Committed: https://skia.googlesource.com/skia/+/bb34a8ac59850f128d9602e629a7475e3ad1a9d2

[reed1, 2016-04-23 12:06:54]

Description was changed from

==========
allow imagefilter to manage CTM decomposition

BUG=skia:
==========

to

==========
allow imagefilter to manage CTM decomposition

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-04-23 12:08:04]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-23 12:08:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908173006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908173006/1

[reed1, 2016-04-23 12:11:25]

reed@google.com changed reviewers:
+ fmalita@chromium.org, robertphillips@google.com, senorblanco@google.com

[commit-bot: I haz the power, 2016-04-23 12:20:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-23 12:21:01]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-04-23 12:38:44]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-23 12:38:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908173006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908173006/20001

[commit-bot: I haz the power, 2016-04-23 12:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-23 12:52:19]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-04-23 14:12:50]

lgtm

https://codereview.chromium.org/1908173006/diff/20001/include/core/SkImageFil...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1908173006/diff/20001/include/core/SkImageFil...
include/core/SkImageFilter.h:218: bool decomposeCTM(const SkMatrix& ctm,
SkMatrix* filterMatrix, SkMatrix* remainder) {
nit: docs

[reed1, 2016-04-23 19:41:58]

simpler approach, canHandleAffine

https://codereview.chromium.org/1908173006/diff/20001/include/core/SkImageFil...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1908173006/diff/20001/include/core/SkImageFil...
include/core/SkImageFilter.h:218: bool decomposeCTM(const SkMatrix& ctm,
SkMatrix* filterMatrix, SkMatrix* remainder) {
On 2016/04/23 14:12:50, f(malita) wrote:
> nit: docs

Done.

[reed1, 2016-04-23 19:42:04]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-23 19:42:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908173006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908173006/40001

[commit-bot: I haz the power, 2016-04-23 19:57:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-23 19:57:23]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-04-23 22:18:07]

The CQ bit was checked by reed@google.com

[reed1, 2016-04-23 22:18:07]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1908173006/#ps40001
(title: "switch to simple canHandleAffine pattern")

[commit-bot: I haz the power, 2016-04-23 22:18:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908173006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908173006/40001

[commit-bot: I haz the power, 2016-04-23 22:19:12]

Description was changed from

==========
allow imagefilter to manage CTM decomposition

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
allow imagefilter to manage CTM decomposition

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/bb34a8ac59850f128d9602e629a7475e3ad1a9d2
==========

[commit-bot: I haz the power, 2016-04-23 22:19:13]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/bb34a8ac59850f128d9602e629a7475e3ad1a9d2

[Stephen White, 2016-04-25 14:09:33]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2016-04-25 14:09:34]

https://codereview.chromium.org/1908173006/diff/40001/include/core/SkImageFil...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1908173006/diff/40001/include/core/SkImageFil...
include/core/SkImageFilter.h:223: bool canHandleAffine() const { return
this->onCanHandleAffine(); }
<bikeshed> Could we add a noun to that? canHandleAffineMatrix() or
canHandleAffineTransforms()? </bikeshed>

https://codereview.chromium.org/1908173006/diff/40001/src/core/SkImageFilter.cpp
File src/core/SkImageFilter.cpp (right):

https://codereview.chromium.org/1908173006/diff/40001/src/core/SkImageFilter....
src/core/SkImageFilter.cpp:333: bool SkImageFilter::onCanHandleAffine() const {
Wouldn't it be simpler to have (non-virtual) canHandleAffine do the recursion,
and make onCanHandleAffine non-recursive? That would keep the subclasses
simpler. Is there a node which needs to control the recursion beyond "I can't
handle affine transforms; abort"?

https://codereview.chromium.org/1908173006/diff/40001/src/core/SkImageFilter....
src/core/SkImageFilter.cpp:347: // If we have no inputs, or 1 or more of them do
not handle affine, then we return false.
Why would a null input imply we can't handle affine transforms? This just means
we're using the input primitive, which is pretty common.

[reed1, 2016-04-25 14:13:35]

https://codereview.chromium.org/1908173006/diff/40001/src/core/SkImageFilter.cpp
File src/core/SkImageFilter.cpp (right):

https://codereview.chromium.org/1908173006/diff/40001/src/core/SkImageFilter....
src/core/SkImageFilter.cpp:333: bool SkImageFilter::onCanHandleAffine() const {
On 2016/04/25 14:09:34, Stephen White wrote:
> Wouldn't it be simpler to have (non-virtual) canHandleAffine do the recursion,
> and make onCanHandleAffine non-recursive? That would keep the subclasses
> simpler. Is there a node which needs to control the recursion beyond "I can't
> handle affine transforms; abort"?

Good idea! See follow-on CL https://codereview.chromium.org/1915943002/