Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1908153002: Replace CFX_ArrayTemplate with std::vector in CPDF_ObjectStream (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace CFX_ArrayTemplate with std::vector in CPDF_ObjectStream Replace two parallel arrays with an array of pairs. Several methods always returned same value, make void instead. Committed: https://pdfium.googlesource.com/pdfium/+/0d2dc680e36b8ba7608cb062efe8488abd388985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -44 lines) Patch
M core/fpdfapi/fpdf_edit/editint.h View 1 chunk +12 lines, -12 lines 0 comments Download
M core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 7 chunks +31 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom Sepez
Lei, for review.
4 years, 8 months ago (2016-04-21 21:18:55 UTC) #3
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-21 22:00:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908153002/1
4 years, 8 months ago (2016-04-21 22:20:25 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 22:20:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/0d2dc680e36b8ba7608cb062efe8488abd38...

Powered by Google App Engine
This is Rietveld 408576698