Convert //components/user_prefs from scoped_ptr to std::unique_ptr

Convert //components/user_prefs from scoped_ptr to std::unique_ptr

BUG=554298
R=gab@chromium.org

Committed: https://crrev.com/b707c5c8bed8656c800f613b46967b916e1a7f44
Cr-Commit-Position: refs/heads/master@{#389204}

[dcheng, 2016-04-21 21:35:32]

Build failures appear to be unrelated.

[gab, 2016-04-22 18:17:32]

lgtm % comments

https://codereview.chromium.org/1908143002/diff/1/components/user_prefs/track...
File components/user_prefs/tracked/device_id_win.cc (right):

https://codereview.chromium.org/1908143002/diff/1/components/user_prefs/track...
components/user_prefs/tracked/device_id_win.cc:8: #include <windows.h>
windows.h always has to be first

https://codereview.chromium.org/1908143002/diff/1/components/user_prefs/track...
File components/user_prefs/tracked/pref_hash_filter.h (right):

https://codereview.chromium.org/1908143002/diff/1/components/user_prefs/track...
components/user_prefs/tracked/pref_hash_filter.h:121:
std::unique_ptr<TrackedPreference>>
Switch to std::unordered_map or is a follow-up cleanup planned for
ScopedPtrHashMap?

[dcheng, 2016-04-22 18:23:32]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-22 18:23:32]

https://codereview.chromium.org/1908143002/diff/1/components/user_prefs/track...
File components/user_prefs/tracked/device_id_win.cc (right):

https://codereview.chromium.org/1908143002/diff/1/components/user_prefs/track...
components/user_prefs/tracked/device_id_win.cc:8: #include <windows.h>
On 2016/04/22 at 18:17:31, gab wrote:
> windows.h always has to be first

Doh, thanks. I had to manually stage a lot of the header diffs, but I missed
this one.

https://codereview.chromium.org/1908143002/diff/1/components/user_prefs/track...
File components/user_prefs/tracked/pref_hash_filter.h (right):

https://codereview.chromium.org/1908143002/diff/1/components/user_prefs/track...
components/user_prefs/tracked/pref_hash_filter.h:121:
std::unique_ptr<TrackedPreference>>
On 2016/04/22 at 18:17:31, gab wrote:
> Switch to std::unordered_map or is a follow-up cleanup planned for
ScopedPtrHashMap?

Out of scope for this cleanup. There's an open bug to migrate these away though:
https://crbug.com/579229

[dcheng, 2016-04-22 18:23:33]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/1908143002/#ps20001
(title: "Restore the rightful glory of <windows.h>")

[commit-bot: I haz the power, 2016-04-22 18:24:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908143002/20001

[commit-bot: I haz the power, 2016-04-22 19:15:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:51:30]

Description was changed from

==========
Convert //components/user_prefs from scoped_ptr to std::unique_ptr

BUG=554298
R=gab@chromium.org
==========

to

==========
Convert //components/user_prefs from scoped_ptr to std::unique_ptr

BUG=554298
R=gab@chromium.org

Committed: https://crrev.com/b707c5c8bed8656c800f613b46967b916e1a7f44
Cr-Commit-Position: refs/heads/master@{#389204}
==========

[commit-bot: I haz the power, 2016-04-22 19:51:31]

Patchset 2 (id:??) landed as
https://crrev.com/b707c5c8bed8656c800f613b46967b916e1a7f44
Cr-Commit-Position: refs/heads/master@{#389204}