Make CFX_BasicArray non-copyable.

Make CFX_BasicArray non-copyable.

Its implicit copy constructor is unsafe, since it ends up
sharing the underlying data.  Fix one place where it was
being unintentionally invoked.

Committed: https://pdfium.googlesource.com/pdfium/+/d00a91229690e453cb7f2eed652d81e864b27d2a

[Tom Sepez, 2016-04-21 18:43:09]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-21 18:43:10]

Lei, for review.

[Lei Zhang, 2016-04-21 18:45:42]

lgtm

[Tom Sepez, 2016-04-21 18:49:01]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-04-21 18:49:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908073003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908073003/1

[commit-bot: I haz the power, 2016-04-21 18:56:03]

Description was changed from

==========
Make CFX_BasicArray non-copyable.

Its implicit copy constructor is unsafe, since it ends up
sharing the underlying data.  Fix one place where it was
being unintentionally invoked.
==========

to

==========
Make CFX_BasicArray non-copyable.

Its implicit copy constructor is unsafe, since it ends up
sharing the underlying data.  Fix one place where it was
being unintentionally invoked.

Committed:
https://pdfium.googlesource.com/pdfium/+/d00a91229690e453cb7f2eed652d81e864b2...
==========

[commit-bot: I haz the power, 2016-04-21 18:56:04]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d00a91229690e453cb7f2eed652d81e864b2...