Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1908043002: [Mac] In unit_tests use the resources.pak in the framework bundle. (Closed)

Created:
4 years, 8 months ago by Robert Sesek
Modified:
4 years, 8 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-chrome
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] In unit_tests use the resources.pak in the framework bundle. There shouldn't be a need to copy resources.pak from the framework bundle to the product dir, since the test suite sets up the framework override path. BUG=431177 Committed: https://crrev.com/fa2d7b928700b564f330801746504a36f692874d Cr-Commit-Position: refs/heads/master@{#389112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M chrome/chrome_dll_bundle.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/test/base/chrome_unit_test_suite.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Robert Sesek
4 years, 8 months ago (2016-04-22 14:22:29 UTC) #2
Mark Mentovai
LGTM. Probably predates the bundle override.
4 years, 8 months ago (2016-04-22 14:25:44 UTC) #3
Robert Sesek
+thakis for //chrome OWNERS
4 years, 8 months ago (2016-04-22 14:47:19 UTC) #5
Nico
lgtm
4 years, 8 months ago (2016-04-22 14:57:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908043002/1
4 years, 8 months ago (2016-04-22 14:58:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 15:36:06 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:47:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa2d7b928700b564f330801746504a36f692874d
Cr-Commit-Position: refs/heads/master@{#389112}

Powered by Google App Engine
This is Rietveld 408576698