Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1908033002: [Interpreter] Fix incorrect Register OperandSize calculation for ExtraWide. (Closed)

Created:
4 years, 8 months ago by rmcilroy
Modified:
4 years, 8 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fix incorrect Register OperandSize calculation for ExtraWide. Fixes a mistake made in r35618 for register OperandSize calculations. BUG=605470 LOG=N Committed: https://crrev.com/11e3ba34f54a67ef1f9a64f572d465c9b2ff5a56 Cr-Commit-Position: refs/heads/master@{#35719}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/interpreter/bytecodes.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-605470.js View 1 chunk +17 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (10 generated)
rmcilroy
PTAL Orion, thanks.
4 years, 8 months ago (2016-04-21 15:11:14 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908033002/1
4 years, 8 months ago (2016-04-21 15:11:49 UTC) #5
oth
On 2016/04/21 15:11:49, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 8 months ago (2016-04-21 15:29:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908033002/1
4 years, 8 months ago (2016-04-21 16:12:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/547)
4 years, 8 months ago (2016-04-21 19:16:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908033002/20001
4 years, 8 months ago (2016-04-22 09:39:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 10:31:12 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:16 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/11e3ba34f54a67ef1f9a64f572d465c9b2ff5a56
Cr-Commit-Position: refs/heads/master@{#35719}

Powered by Google App Engine
This is Rietveld 408576698