Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1907993003: [chromedriver] Use snapshot instead of continuous archive, drop M48 and add M51. (Closed)

Created:
4 years, 8 months ago by gmanikpure
Modified:
4 years, 8 months ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Use snapshot instead of continuous archive, drop M48 and add M51. This is because the continuous archive is no longer being updated. Also delete the blink snapshot archive, since that is also no longer being updated. Committed: https://crrev.com/8a1ff19a5e4652c744d063b9963e6610a1f97db1 Cr-Commit-Position: refs/heads/master@{#388911}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove BLINK_SNAPSHOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M chrome/test/chromedriver/archive.py View 1 3 chunks +8 lines, -10 lines 0 comments Download
M chrome/test/chromedriver/chrome/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/test/run_all_tests.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
gmanikpure
Hi Sam, Could you please take a look? Thanks
4 years, 8 months ago (2016-04-21 17:39:16 UTC) #3
samuong
https://codereview.chromium.org/1907993003/diff/1/chrome/test/chromedriver/archive.py File chrome/test/chromedriver/archive.py (right): https://codereview.chromium.org/1907993003/diff/1/chrome/test/chromedriver/archive.py#newcode28 chrome/test/chromedriver/archive.py:28: BLINK_SNAPSHOT = _SITE + '/chromium-webkit-snapshots' while we're here, let's ...
4 years, 8 months ago (2016-04-21 18:49:47 UTC) #4
gmanikpure
https://codereview.chromium.org/1907993003/diff/1/chrome/test/chromedriver/archive.py File chrome/test/chromedriver/archive.py (right): https://codereview.chromium.org/1907993003/diff/1/chrome/test/chromedriver/archive.py#newcode28 chrome/test/chromedriver/archive.py:28: BLINK_SNAPSHOT = _SITE + '/chromium-webkit-snapshots' On 2016/04/21 18:49:47, samuong ...
4 years, 8 months ago (2016-04-21 19:00:36 UTC) #5
samuong
lgtm I've also tweaked your description, to make it a bit shorter and add the ...
4 years, 8 months ago (2016-04-21 19:47:25 UTC) #8
gmanikpure
On 2016/04/21 19:47:25, samuong wrote: > lgtm > > I've also tweaked your description, to ...
4 years, 8 months ago (2016-04-21 20:52:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907993003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907993003/20001
4 years, 8 months ago (2016-04-21 20:53:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 21:44:40 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:39:59 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a1ff19a5e4652c744d063b9963e6610a1f97db1
Cr-Commit-Position: refs/heads/master@{#388911}

Powered by Google App Engine
This is Rietveld 408576698