Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Issue 1907963002: [turbofan] Reorganize the pipeline around the 2nd scheduler approach. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reorganize the pipeline around the 2nd scheduler approach. The JavaScript pipeline now consists of the following steps: 1. Typed lowering. 2. Representation selection (actually SimplifiedLowering). 3. Early optimization pass (incl. JSGenericLowering). 4. Effect control linearization (not for asm.js). 5. Late optimization pass (incl. ChangeLowering). 6. Real scheduling. We should further cleanup the passes and restrict type and representation information usage to appropriate parts of the pipeline. R=jarin@chromium.org Committed: https://crrev.com/5e11acc9dc28fedee6c777b27a0730ef2607ee11 Cr-Commit-Position: refs/heads/master@{#35702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -39 lines) Patch
M src/compiler/pipeline.cc View 8 chunks +26 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-21 11:27:05 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the first round of cleanups. Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-04-21 11:29:58 UTC) #2
Jarin
lgtm
4 years, 8 months ago (2016-04-21 11:31:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907963002/1
4 years, 8 months ago (2016-04-21 11:31:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 11:49:02 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e11acc9dc28fedee6c777b27a0730ef2607ee11
Cr-Commit-Position: refs/heads/master@{#35702}

Powered by Google App Engine
This is Rietveld 408576698