Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1907953002: Make sure we always try to make prototypes fast again when transitioning accessors (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make sure we always try to make prototypes fast again when transitioning accessors BUG=chromium:605060 LOG=n Committed: https://crrev.com/4a6a0f553061cc4a6543d683fe07040c19c77d24 Cr-Commit-Position: refs/heads/master@{#35697}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M src/lookup.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-605060.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Toon Verwaest
This code needs some love. Just a bugfix for now ... ishell: ptal bmeurer: fyi
4 years, 8 months ago (2016-04-21 09:55:37 UTC) #2
Igor Sheludko
lgtm if you uncomment the new line :)
4 years, 8 months ago (2016-04-21 09:58:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907953002/20001
4 years, 8 months ago (2016-04-21 10:49:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 11:16:47 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:32 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a6a0f553061cc4a6543d683fe07040c19c77d24
Cr-Commit-Position: refs/heads/master@{#35697}

Powered by Google App Engine
This is Rietveld 408576698