Introduce FrameAndConstantPoolScope and ConstantPoolUnavailableScope.

Introduce FrameAndConstantPoolScope and ConstantPoolUnavailableScope.

Adds FrameAndConstantPoolScope and ConstantPoolUnavailableScope to enable
scoped management of constant pool availability.  Also load constant pool
pointer when entering an internal frame scope.

R=rodolph.perfetta@arm.com, ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=19858

[rmcilroy, 2014-03-07 18:53:02]

Part of the out-of-line constant pool change - PTAL.

[ulan, 2014-03-11 13:00:46]

lgtm

https://codereview.chromium.org/190793002/diff/1/src/arm/assembler-arm.h
File src/arm/assembler-arm.h (right):

https://codereview.chromium.org/190793002/diff/1/src/arm/assembler-arm.h#newc...
src/arm/assembler-arm.h:1579: bool constant_pool_full_;
Could you add a comment explaining what constant_pool_full_ indicates?

https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm....
src/arm/macro-assembler-arm.h:1520: // manual or none frame type.
Did you mean to assert (type_ != StackFrame::MANUAL && type_ !=
StackFrame::NONE) here ?

[Rodolph Perfetta (ARM), 2014-03-11 13:28:34]

https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm....
src/arm/macro-assembler-arm.cc:894: Code::kConstantPoolOffset -
Code::kHeaderSize - pc_offset() - 8;
8 -> kPCReadOffset

https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm....
src/arm/macro-assembler-arm.h:1531:
masm_->set_constant_pool_available(old_has_frame_);
old_constant_pool_available_

[rmcilroy, 2014-03-11 16:36:34]

Thanks for the review. Comments addressed, PTAL

https://codereview.chromium.org/190793002/diff/1/src/arm/assembler-arm.h
File src/arm/assembler-arm.h (right):

https://codereview.chromium.org/190793002/diff/1/src/arm/assembler-arm.h#newc...
src/arm/assembler-arm.h:1579: bool constant_pool_full_;
On 2014/03/11 13:00:46, ulan wrote:
> Could you add a comment explaining what constant_pool_full_ indicates?

Done (and for constant_pool_available)

https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm....
src/arm/macro-assembler-arm.cc:894: Code::kConstantPoolOffset -
Code::kHeaderSize - pc_offset() - 8;
On 2014/03/11 13:28:34, Rodolph Perfetta (ARM) wrote:
> 8 -> kPCReadOffset

Done.

https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm....
src/arm/macro-assembler-arm.h:1520: // manual or none frame type.
On 2014/03/11 13:00:46, ulan wrote:
> Did you mean to assert (type_ != StackFrame::MANUAL && type_ !=
> StackFrame::NONE) here ?

Ahh originally had this assert, but changed it to allow StackFrame::Manual which
set the CP to use this scoped object.  Removed the comment - thanks.

https://codereview.chromium.org/190793002/diff/1/src/arm/macro-assembler-arm....
src/arm/macro-assembler-arm.h:1531:
masm_->set_constant_pool_available(old_has_frame_);
On 2014/03/11 13:28:34, Rodolph Perfetta (ARM) wrote:
> old_constant_pool_available_

Done thanks (I had this change, but it seemed to have ended up in the wrong
local branch / CL somehow...)

[Rodolph Perfetta (ARM), 2014-03-12 14:49:28]

lgtm

[rmcilroy, 2014-03-12 15:56:27]

Committed patchset #3 manually as r19858 (presubmit successful).