Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1907923003: [compiler] Remove obsolete check for debug break slots. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove obsolete check for debug break slots. This check whether a function is being debugged is obsolete. For the optimization path it is covered by a bailout further down. The lookup within the optimized code map doesn't need to be covered, because that map is guaranteed to stay empty while break slots are present. R=mvstanton@chromium.org Committed: https://crrev.com/c323d2a64eb344ebe256861b8e89d5b5d0dc0146 Cr-Commit-Position: refs/heads/master@{#35694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-21 08:50:22 UTC) #2
mvstanton
lgtm
4 years, 8 months ago (2016-04-21 08:56:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907923003/1
4 years, 8 months ago (2016-04-21 09:52:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 10:13:30 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c323d2a64eb344ebe256861b8e89d5b5d0dc0146
Cr-Commit-Position: refs/heads/master@{#35694}

Powered by Google App Engine
This is Rietveld 408576698