Chromium Code Reviews| Index: chrome/test/nacl/nacl_browsertest_util.h |
| diff --git a/chrome/test/nacl/nacl_browsertest_util.h b/chrome/test/nacl/nacl_browsertest_util.h |
| index 914f6ebc49956bf980feacd0a485ca7092dda702..16e445f90896d7fe4dcd0211fb040a53b29f98d2 100644 |
| --- a/chrome/test/nacl/nacl_browsertest_util.h |
| +++ b/chrome/test/nacl/nacl_browsertest_util.h |
| @@ -74,7 +74,9 @@ class NaClBrowserTestBase : public InProcessBrowserTest { |
| // Where are the files for this class of test located on disk? |
| virtual bool GetDocumentRoot(base::FilePath* document_root); |
| - virtual bool IsPnacl(); |
| + virtual bool IsAPnaclTest(); |
| + |
| + virtual bool IsPnaclDisabled(); |
| // Map a file relative to the variant directory to a URL served by the test |
| // web server. |
| @@ -120,7 +122,20 @@ class NaClBrowserTestPnacl : public NaClBrowserTestBase { |
| virtual base::FilePath::StringType Variant() OVERRIDE; |
| - virtual bool IsPnacl() OVERRIDE; |
| + virtual bool IsAPnaclTest() OVERRIDE; |
| +}; |
| + |
| +// Class used to test that when --disable-pnacl is specified the PNaCl mime |
| +// type is not available. |
| +class NaClBrowserTestPnaclDisabled : public NaClBrowserTestBase { |
| + public: |
| + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE; |
| + |
| + virtual base::FilePath::StringType Variant() OVERRIDE; |
| + |
| + virtual bool IsAPnaclTest() OVERRIDE; |
| + |
| + virtual bool IsPnaclDisabled() OVERRIDE; |
| }; |
| // Temporary class for running tests with the new cache enabled. Once all the |
| @@ -157,7 +172,7 @@ body |
| #else |
| -// Otherwise, we have Glibc, Newlib and PNaCl tests |
| +// Otherwise, we have Glibc, Newlib, Pnacl, and PnaclDisabled tests |
|
jvoung (off chromium)
2013/07/23 23:16:00
PnaclDisabled shouldn't be in this "test-all" list
sehr
2013/07/24 00:39:14
I left this as a vestige of an earlier attempt. R
|
| #define NACL_BROWSER_TEST_F(suite, name, body) \ |
| IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \ |
| body \ |