Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: ash/shell.cc

Issue 1907863002: Converts DockedWindowLayoutManager to common ash/wm types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: explicit shutdown Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index a24d502c0db8340311ae0b532fca1fc09cbc0b7c..2034fa3b65bc0f636d99932e976d8cb6625d051a 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -221,7 +221,6 @@ bool Shell::HasInstance() {
// static
void Shell::DeleteInstance() {
delete instance_;
- instance_ = nullptr;
}
// static
@@ -817,6 +816,10 @@ Shell::~Shell() {
display_manager_->CreateScreenForShutdown();
display_configuration_controller_.reset();
+ // Needs to happen before |window_tree_host_manager_|. Callback to Shell, so
varkha 2016/04/21 17:46:55 nit: s/Callback/Calls back?
sky 2016/04/21 18:03:04 Done.
+ // also needs to be destroyed before |instance_| reset to null.
+ wm_globals_.reset();
+
// Depends on |focus_client_|, so must be destroyed before.
window_tree_host_manager_->Shutdown();
window_tree_host_manager_.reset();

Powered by Google App Engine
This is Rietveld 408576698