MD Settings: fix bug where "RESET THEME" opens theme gallery

MD Settings: fix bug where "RESET THEME" opens theme gallery

R=dschuyler@chromium.org
BUG=605075
Committed: https://crrev.com/128077b165c9860d9c51f96bee506dba3cb505c9
Cr-Commit-Position: refs/heads/master@{#388962}

[Dan Beam, 2016-04-21 03:44:43]

I'm wondering how I should test this.

also, it's weird to me that this isn't reproducing on Linux.

[dschuyler, 2016-04-21 18:02:24]

On 2016/04/21 03:44:43, Dan Beam wrote:
> I'm wondering how I should test this.
> 
> also, it's weird to me that this isn't reproducing on Linux.

I think this came up from CL 1867803004.  I seem to have
partially fixed it in CL 1896283003 but missed the ChromeOS
version that would still have the issue (around line 43 of
appearance_page.html).

I believe this can be fixed by removing the on-tap from this
line:
<div class="settings-box two-line" on-tap="openThemesGallery_">

[Dan Beam, 2016-04-21 18:42:18]

On 2016/04/21 18:02:24, dschuyler wrote:
> On 2016/04/21 03:44:43, Dan Beam wrote:
> > I'm wondering how I should test this.
> > 
> > also, it's weird to me that this isn't reproducing on Linux.
> 
> I think this came up from CL 1867803004.  I seem to have
> partially fixed it in CL 1896283003 but missed the ChromeOS
> version that would still have the issue (around line 43 of
> appearance_page.html).
> 
> I believe this can be fixed by removing the on-tap from this
> line:
> <div class="settings-box two-line" on-tap="openThemesGallery_">

Done.

[dschuyler, 2016-04-21 23:21:09]

lgtm

[Dan Beam, 2016-04-21 23:21:53]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-04-21 23:22:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907843002/20001

[commit-bot: I haz the power, 2016-04-22 00:03:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:41:55]

Description was changed from

==========
MD Settings: fix bug where "RESET THEME" opens theme gallery

R=dschuyler@chromium.org
BUG=605075
==========

to

==========
MD Settings: fix bug where "RESET THEME" opens theme gallery

R=dschuyler@chromium.org
BUG=605075

Committed: https://crrev.com/128077b165c9860d9c51f96bee506dba3cb505c9
Cr-Commit-Position: refs/heads/master@{#388962}
==========

[commit-bot: I haz the power, 2016-04-22 19:41:57]

Patchset 2 (id:??) landed as
https://crrev.com/128077b165c9860d9c51f96bee506dba3cb505c9
Cr-Commit-Position: refs/heads/master@{#388962}