Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1907843002: MD Settings: fix bug where "RESET THEME" opens theme gallery (Closed)

Created:
4 years, 8 months ago by Dan Beam
Modified:
4 years, 8 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix bug where "RESET THEME" opens theme gallery R=dschuyler@chromium.org BUG=605075 Committed: https://crrev.com/128077b165c9860d9c51f96bee506dba3cb505c9 Cr-Commit-Position: refs/heads/master@{#388962}

Patch Set 1 #

Patch Set 2 : dschuyler review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Dan Beam
I'm wondering how I should test this. also, it's weird to me that this isn't ...
4 years, 8 months ago (2016-04-21 03:44:43 UTC) #1
dschuyler
On 2016/04/21 03:44:43, Dan Beam wrote: > I'm wondering how I should test this. > ...
4 years, 8 months ago (2016-04-21 18:02:24 UTC) #2
Dan Beam
On 2016/04/21 18:02:24, dschuyler wrote: > On 2016/04/21 03:44:43, Dan Beam wrote: > > I'm ...
4 years, 8 months ago (2016-04-21 18:42:18 UTC) #3
dschuyler
lgtm
4 years, 8 months ago (2016-04-21 23:21:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907843002/20001
4 years, 8 months ago (2016-04-21 23:22:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 00:03:10 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:41:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/128077b165c9860d9c51f96bee506dba3cb505c9
Cr-Commit-Position: refs/heads/master@{#388962}

Powered by Google App Engine
This is Rietveld 408576698