chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js - Issue 1907813002: Make the URLs in the password exceptions list clickable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

Issue 1907813002: Make the URLs in the password exceptions list clickable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-implicit-update.gitbr

Patch Set: feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc ('k') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

index a13c9c82373b16c8858433e42cfdd5a165dece2f..f7ce107edf9fd8a66f24cc1d1b6bf314ddf3af5c 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

@@ -19,6 +19,9 @@ PasswordManager.PasswordUiEntry;

/** @typedef {chrome.passwordsPrivate.LoginPair} */

PasswordManager.LoginPair;

+/** @typedef {chrome.passwordsPrivate.ExceptionPair} */

+PasswordManager.ExceptionPair;

/** @typedef {chrome.passwordsPrivate.PlaintextPasswordEventParameters} */

PasswordManager.PlaintextPasswordEvent;

@@ -38,7 +41,7 @@ PasswordManager.prototype = {

/**

* Request the list of password exceptions and observe future changes.

- * @param {function(!Array<!string>):void} callback

+ * @param {function(!Array<!PasswordManager.ExceptionPair>):void} callback

setExceptionListChangedCallback: assertNotReached,

@@ -147,7 +150,7 @@ Polymer({

/**

* An array of sites to display.

- * @type {!Array<!string>}

+ * @type {!Array<!PasswordManager.ExceptionPair>}

passwordExceptions: {

type: Array,