Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2354)

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc

Issue 1907813002: Make the URLs in the password exceptions list clickable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-implicit-update.gitbr
Patch Set: feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc
diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc
index db2589d7fa322ab06b60605fe4d0f38d7d655b37..f332e3ef2d7140918b85f02330fb98f1d811a8ed 100644
--- a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc
+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc
@@ -61,7 +61,7 @@ void PasswordsPrivateDelegateImpl::SendPasswordExceptionsList() {
router->OnPasswordExceptionsListChanged(current_exceptions_);
}
-const std::vector<std::string>*
+const std::vector<api::passwords_private::ExceptionPair>*
PasswordsPrivateDelegateImpl::GetPasswordExceptionsList() const {
return &current_exceptions_;
}
@@ -208,8 +208,10 @@ void PasswordsPrivateDelegateImpl::SetPasswordExceptionList(
// Now, create a list of exceptions to send to observers.
current_exceptions_.clear();
for (const auto& form : password_exception_list) {
- current_exceptions_.push_back(
- password_manager::GetHumanReadableOrigin(*form));
+ api::passwords_private::ExceptionPair pair;
+ pair.exception_url = password_manager::GetHumanReadableOrigin(*form);
+ pair.link_url = form->origin.spec();
+ current_exceptions_.push_back(std::move(pair));
}
SendPasswordExceptionsList();

Powered by Google App Engine
This is Rietveld 408576698