Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc

Issue 1907813002: Make the URLs in the password exceptions list clickable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-implicit-update.gitbr
Patch Set: feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
index d24bbe3052b32de31bbfb076a2a23286e97ccc3b..d5e30ab20d3d9b59c1687d0c282e5435dbb7bc3d 100644
--- a/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
@@ -37,6 +37,8 @@ api::passwords_private::PasswordUiEntry CreateEntry(size_t num) {
std::stringstream ss;
ss << "http://test" << num << ".com";
entry.login_pair.origin_url = ss.str();
+ ss << "/login";
+ entry.link_url = ss.str();
ss.clear();
ss << "testName" << num;
entry.login_pair.username = ss.str();
@@ -44,10 +46,14 @@ api::passwords_private::PasswordUiEntry CreateEntry(size_t num) {
return entry;
}
-std::string CreateException(size_t num) {
+api::passwords_private::ExceptionPair CreateException(size_t num) {
+ api::passwords_private::ExceptionPair exception;
std::stringstream ss;
ss << "http://exception" << num << ".com";
- return ss.str();
+ exception.exception_url = ss.str();
+ ss << "/login";
+ exception.link_url = ss.str();
+ return exception;
}
// A test PasswordsPrivateDelegate implementation which uses mock data.
@@ -84,7 +90,8 @@ class TestDelegate : public PasswordsPrivateDelegate {
router->OnPasswordExceptionsListChanged(current_exceptions_);
}
- const std::vector<std::string>* GetPasswordExceptionsList() const override {
+ const std::vector<api::passwords_private::ExceptionPair>*
+ GetPasswordExceptionsList() const override {
return &current_exceptions_;
}
@@ -129,7 +136,7 @@ class TestDelegate : public PasswordsPrivateDelegate {
// observers are added, this delegate can send the current lists without
// having to request them from |password_manager_presenter_| again.
std::vector<api::passwords_private::PasswordUiEntry> current_entries_;
- std::vector<std::string> current_exceptions_;
+ std::vector<api::passwords_private::ExceptionPair> current_exceptions_;
Profile* profile_;
};
« no previous file with comments | « no previous file | chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698