Make the URLs in the password exceptions list clickable.

chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <sstream>
 
 #include "base/command_line.h"
 #include "base/macros.h"
@@ skipping 26 matching lines @@
   std::stringstream ss;
   ss << "http://test" << num << ".com";
   entry.login_pair.origin_url = ss.str();
   ss.clear();
   ss << "testName" << num;
   entry.login_pair.username = ss.str();
   entry.num_characters_in_password = kNumCharactersInPassword;
   return entry;
 }
 
-std::string CreateException(size_t num) {
+api::passwords_private::ExceptionPair CreateException(size_t num) {
+  api::passwords_private::ExceptionPair exception;
   std::stringstream ss;
   ss << "http://exception" << num << ".com";
-  return ss.str();
+  exception.exception_url = ss.str();
+  exception.link_url = ss.str();

[stevenjb, 2016/04/22 16:11:20]

nit: we should probably test with a different link url

[hcarmona, 2016/04/23 01:46:08]

Done.

+  return exception;
 }
 
 // A test PasswordsPrivateDelegate implementation which uses mock data.
 // TestDelegate starts out with kNumMocks mocks of each type (saved password
 // and password exception) and removes one mock each time RemoveSavedPassword()
 // or RemovePasswordException() is called.
 class TestDelegate : public PasswordsPrivateDelegate {
  public:
   TestDelegate() : profile_(nullptr) {
     // Create mock data.
@@ skipping 16 matching lines @@
     return &current_entries_;
   }
 
   void SendPasswordExceptionsList() override {
     PasswordsPrivateEventRouter* router =
         PasswordsPrivateEventRouterFactory::GetForProfile(profile_);
     if (router)
       router->OnPasswordExceptionsListChanged(current_exceptions_);
   }
 
-  const std::vector<std::string>* GetPasswordExceptionsList() const override {
+  const std::vector<api::passwords_private::ExceptionPair>*
+  GetPasswordExceptionsList() const override {
     return &current_exceptions_;
   }
 
   void RemoveSavedPassword(
       const std::string& origin_url, const std::string& username) override {
     if (!current_entries_.size())
       return;
 
     // Since this is just mock data, remove the first entry regardless of
     // the data contained.
@@ skipping 24 matching lines @@
     }
   }
 
   void SetProfile(Profile* profile) { profile_ = profile; }
 
  private:
   // The current list of entries/exceptions. Cached here so that when new
   // observers are added, this delegate can send the current lists without
   // having to request them from |password_manager_presenter_| again.
   std::vector<api::passwords_private::PasswordUiEntry> current_entries_;
-  std::vector<std::string> current_exceptions_;
+  std::vector<api::passwords_private::ExceptionPair> current_exceptions_;
   Profile* profile_;
 };
 
 class PasswordsPrivateApiTest : public ExtensionApiTest {
  public:
   PasswordsPrivateApiTest() {
     if (!s_test_delegate_) {
       s_test_delegate_ = new TestDelegate();
     }
   }
@@ skipping 53 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(PasswordsPrivateApiTest, GetSavedPasswordList) {
   EXPECT_TRUE(RunPasswordsSubtest("getSavedPasswordList")) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(PasswordsPrivateApiTest, GetPasswordExceptionList) {
   EXPECT_TRUE(RunPasswordsSubtest("getPasswordExceptionList")) << message_;
 }
 
 }  // namespace extensions