Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1907743002: Add heart beat tests to make sure we see an isolate's sticky error after exit (Closed)

Created:
4 years, 8 months ago by Cutch
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add heart beat tests to make sure we see an isolate's sticky error after exit BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/204031ea6186982dd15304803eeb71ce2e4d82f3

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -18 lines) Patch
A runtime/observatory/tests/service/get_isolate_after_async_error_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/service/get_isolate_after_language_error_test.dart View 1 1 chunk +12 lines, -9 lines 0 comments Download
A + runtime/observatory/tests/service/get_isolate_after_sync_error_test.dart View 2 chunks +8 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/service_test_common.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
4 years, 8 months ago (2016-04-20 23:23:37 UTC) #3
rmacnak
LGTM
4 years, 8 months ago (2016-04-20 23:46:53 UTC) #4
Cutch
4 years, 8 months ago (2016-04-21 14:20:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
204031ea6186982dd15304803eeb71ce2e4d82f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698