chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 1907703002: Fix a nasty scroll bug for Chrome Now-on-tap feature. Also combine the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1907703002: Fix a nasty scroll bug for Chrome Now-on-tap feature. Also combine the (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix findbug issue (remove unused variable) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeVersionInfo.java ('k') | content/browser/android/content_view_core_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index 2b776b7039282178f110c1c3015708de3568bd4f..308d418a1468185ae64aeef1cba5b67d9d9d691b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -39,6 +39,7 @@ import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.ChromeApplication;

+import org.chromium.chrome.browser.ChromeVersionInfo;

import org.chromium.chrome.browser.FrozenNativePage;

import org.chromium.chrome.browser.IntentHandler;

import org.chromium.chrome.browser.IntentHandler.TabOpenType;

@@ -503,6 +504,11 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

}

};

}

+ @Override

+ public String getProductVersion() {

+ return ChromeVersionInfo.getProductVersion();

+ }

}

private GestureStateListener createGestureStateListener() {