Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1907703002: Fix a nasty scroll bug for Chrome Now-on-tap feature. Also combine the (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add hint back Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.tab; 5 package org.chromium.chrome.browser.tab;
6 6
7 import android.app.Activity; 7 import android.app.Activity;
8 import android.content.Context; 8 import android.content.Context;
9 import android.content.Intent; 9 import android.content.Intent;
10 import android.content.res.Resources; 10 import android.content.res.Resources;
(...skipping 21 matching lines...) Expand all
32 import org.chromium.base.ObserverList.RewindableIterator; 32 import org.chromium.base.ObserverList.RewindableIterator;
33 import org.chromium.base.ThreadUtils; 33 import org.chromium.base.ThreadUtils;
34 import org.chromium.base.TraceEvent; 34 import org.chromium.base.TraceEvent;
35 import org.chromium.base.VisibleForTesting; 35 import org.chromium.base.VisibleForTesting;
36 import org.chromium.base.annotations.CalledByNative; 36 import org.chromium.base.annotations.CalledByNative;
37 import org.chromium.base.metrics.RecordHistogram; 37 import org.chromium.base.metrics.RecordHistogram;
38 import org.chromium.base.metrics.RecordUserAction; 38 import org.chromium.base.metrics.RecordUserAction;
39 import org.chromium.chrome.R; 39 import org.chromium.chrome.R;
40 import org.chromium.chrome.browser.ChromeActivity; 40 import org.chromium.chrome.browser.ChromeActivity;
41 import org.chromium.chrome.browser.ChromeApplication; 41 import org.chromium.chrome.browser.ChromeApplication;
42 import org.chromium.chrome.browser.ChromeVersionInfo;
42 import org.chromium.chrome.browser.FrozenNativePage; 43 import org.chromium.chrome.browser.FrozenNativePage;
43 import org.chromium.chrome.browser.IntentHandler; 44 import org.chromium.chrome.browser.IntentHandler;
44 import org.chromium.chrome.browser.IntentHandler.TabOpenType; 45 import org.chromium.chrome.browser.IntentHandler.TabOpenType;
45 import org.chromium.chrome.browser.NativePage; 46 import org.chromium.chrome.browser.NativePage;
46 import org.chromium.chrome.browser.SwipeRefreshHandler; 47 import org.chromium.chrome.browser.SwipeRefreshHandler;
47 import org.chromium.chrome.browser.TabState; 48 import org.chromium.chrome.browser.TabState;
48 import org.chromium.chrome.browser.TabState.WebContentsState; 49 import org.chromium.chrome.browser.TabState.WebContentsState;
49 import org.chromium.chrome.browser.UrlConstants; 50 import org.chromium.chrome.browser.UrlConstants;
50 import org.chromium.chrome.browser.WebContentsFactory; 51 import org.chromium.chrome.browser.WebContentsFactory;
51 import org.chromium.chrome.browser.banners.AppBannerManager; 52 import org.chromium.chrome.browser.banners.AppBannerManager;
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
496 fullscreenManager.setOverlayVideoMode(false); 497 fullscreenManager.setOverlayVideoMode(false);
497 // Disable double tap for video. 498 // Disable double tap for video.
498 if (getContentViewCore() != null) { 499 if (getContentViewCore() != null) {
499 getContentViewCore().updateDoubleTapSupport(true); 500 getContentViewCore().updateDoubleTapSupport(true);
500 } 501 }
501 } 502 }
502 super.exitFullscreenVideo(); 503 super.exitFullscreenVideo();
503 } 504 }
504 }; 505 };
505 } 506 }
507
508 @Override
509 public String getProductVersion() {
510 return ChromeVersionInfo.getProductVersion();
511 }
506 } 512 }
507 513
508 private GestureStateListener createGestureStateListener() { 514 private GestureStateListener createGestureStateListener() {
509 return new GestureStateListener() { 515 return new GestureStateListener() {
510 @Override 516 @Override
511 public void onFlingStartGesture(int vx, int vy, int scrollOffsetY, i nt scrollExtentY) { 517 public void onFlingStartGesture(int vx, int vy, int scrollOffsetY, i nt scrollExtentY) {
512 onScrollingStateChanged(); 518 onScrollingStateChanged();
513 } 519 }
514 520
515 @Override 521 @Override
(...skipping 2645 matching lines...) Expand 10 before | Expand all | Expand 10 after
3161 private native void nativeSetInterceptNavigationDelegate(long nativeTabAndro id, 3167 private native void nativeSetInterceptNavigationDelegate(long nativeTabAndro id,
3162 InterceptNavigationDelegate delegate); 3168 InterceptNavigationDelegate delegate);
3163 private native void nativeAttachToTabContentManager(long nativeTabAndroid, 3169 private native void nativeAttachToTabContentManager(long nativeTabAndroid,
3164 TabContentManager tabContentManager); 3170 TabContentManager tabContentManager);
3165 private native void nativeAttachOverlayContentViewCore(long nativeTabAndroid , 3171 private native void nativeAttachOverlayContentViewCore(long nativeTabAndroid ,
3166 ContentViewCore content, boolean visible); 3172 ContentViewCore content, boolean visible);
3167 private native void nativeDetachOverlayContentViewCore(long nativeTabAndroid , 3173 private native void nativeDetachOverlayContentViewCore(long nativeTabAndroid ,
3168 ContentViewCore content); 3174 ContentViewCore content);
3169 private native boolean nativeHasPrerenderedUrl(long nativeTabAndroid, String url); 3175 private native boolean nativeHasPrerenderedUrl(long nativeTabAndroid, String url);
3170 } 3176 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698