Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: content/browser/android/content_view_core_impl.h

Issue 1907703002: Fix a nasty scroll bug for Chrome Now-on-tap feature. Also combine the (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix findbug issue (remove unused variable) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
6 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 6 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 void AttachLayer(scoped_refptr<cc::Layer> layer); 384 void AttachLayer(scoped_refptr<cc::Layer> layer);
385 void RemoveLayer(scoped_refptr<cc::Layer> layer); 385 void RemoveLayer(scoped_refptr<cc::Layer> layer);
386 386
387 void MoveRangeSelectionExtent(const gfx::PointF& extent); 387 void MoveRangeSelectionExtent(const gfx::PointF& extent);
388 388
389 void SelectBetweenCoordinates(const gfx::PointF& base, 389 void SelectBetweenCoordinates(const gfx::PointF& base,
390 const gfx::PointF& extent); 390 const gfx::PointF& extent);
391 391
392 void OnShowUnhandledTapUIIfNeeded(int x_dip, int y_dip); 392 void OnShowUnhandledTapUIIfNeeded(int x_dip, int y_dip);
393 393
394 // returns page density (dpi) X page scale
395 float GetScaleFactor() const;
396 private: 394 private:
397 class ContentViewUserData; 395 class ContentViewUserData;
398 396
399 friend class ContentViewUserData; 397 friend class ContentViewUserData;
400 ~ContentViewCoreImpl() override; 398 ~ContentViewCoreImpl() override;
401 399
402 // WebContentsObserver implementation. 400 // WebContentsObserver implementation.
403 void RenderViewReady() override; 401 void RenderViewReady() override;
404 void RenderViewHostChanged(RenderViewHost* old_host, 402 void RenderViewHostChanged(RenderViewHost* old_host,
405 RenderViewHost* new_host) override; 403 RenderViewHost* new_host) override;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 scoped_refptr<GinJavaBridgeDispatcherHost> java_bridge_dispatcher_host_; 470 scoped_refptr<GinJavaBridgeDispatcherHost> java_bridge_dispatcher_host_;
473 471
474 DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl); 472 DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl);
475 }; 473 };
476 474
477 bool RegisterContentViewCore(JNIEnv* env); 475 bool RegisterContentViewCore(JNIEnv* env);
478 476
479 } // namespace content 477 } // namespace content
480 478
481 #endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 479 #endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698