Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1907693002: Avoid renderer kills for missing NavigationHandle in DidFail. (Closed)

Created:
4 years, 8 months ago by Charlie Reis
Modified:
4 years, 8 months ago
Reviewers:
clamy, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid renderer kills for missing NavigationHandle in DidFail. TBR=clamy BUG=605289 TEST=Fewer renderer kills in the stability data. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/ec53a5efe2db2eaf81f43e69430a128a7fe5ec31 Cr-Commit-Position: refs/heads/master@{#388680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Charlie Reis
Nasko, can you take a look? This undoes one of the kills from https://codereview.chromium.org/1880423002/, and ...
4 years, 8 months ago (2016-04-20 21:56:34 UTC) #3
nasko
LGTM
4 years, 8 months ago (2016-04-20 22:03:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907693002/1
4 years, 8 months ago (2016-04-20 22:21:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/9469)
4 years, 8 months ago (2016-04-20 23:39:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907693002/1
4 years, 8 months ago (2016-04-21 00:05:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 03:12:13 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:31:06 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec53a5efe2db2eaf81f43e69430a128a7fe5ec31
Cr-Commit-Position: refs/heads/master@{#388680}

Powered by Google App Engine
This is Rietveld 408576698