components/sync_driver/local_device_info_provider_unittest.cc - Issue 1907683003: Convert //components/sync_driver from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/local_device_info_provider_unittest.cc

Issue 1907683003: Convert //components/sync_driver from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Build fix, address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/local_device_info_provider_mock.cc ('k') | components/sync_driver/non_blocking_data_type_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/local_device_info_provider_unittest.cc

diff --git a/components/sync_driver/local_device_info_provider_unittest.cc b/components/sync_driver/local_device_info_provider_unittest.cc

index 21b7cedd903c774bac21babe2f9552d0d877d808..ba8a6c46e500c6d01985170cfd8b4fbd52b504da 100644

--- a/components/sync_driver/local_device_info_provider_unittest.cc

+++ b/components/sync_driver/local_device_info_provider_unittest.cc

@@ -44,7 +44,7 @@ class SyncLocalDeviceInfoProviderTest : public testing::Test {

// Subscribe to the notification and wait until the callback

// is called. The callback will quit the loop.

base::RunLoop run_loop;

- scoped_ptr<LocalDeviceInfoProvider::Subscription> subscription(

+ std::unique_ptr<LocalDeviceInfoProvider::Subscription> subscription(

provider_->RegisterOnInitializedCallback(

base::Bind(&SyncLocalDeviceInfoProviderTest::QuitLoopOnInitialized,

base::Unretained(this), &run_loop)));

@@ -56,7 +56,7 @@ class SyncLocalDeviceInfoProviderTest : public testing::Test {

loop->Quit();

}

- scoped_ptr<LocalDeviceInfoProviderImpl> provider_;

+ std::unique_ptr<LocalDeviceInfoProviderImpl> provider_;

bool called_back_;