components/sync_driver/about_sync_util.h - Issue 1907683003: Convert //components/sync_driver from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/about_sync_util.h

Issue 1907683003: Convert //components/sync_driver from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Build fix, address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browser_sync/browser/profile_sync_components_factory_impl.cc ('k') | components/sync_driver/about_sync_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/about_sync_util.h

diff --git a/components/sync_driver/about_sync_util.h b/components/sync_driver/about_sync_util.h

index 190afc37e53b9e4e2f24c23f239ad9cc35766c64..a0b7fed14cf1ccc9c1953f10cf9792c3e99eec02 100644

--- a/components/sync_driver/about_sync_util.h

+++ b/components/sync_driver/about_sync_util.h

@@ -5,7 +5,8 @@

#ifndef COMPONENTS_SYNC_DRIVER_ABOUT_SYNC_UTIL_H_

#define COMPONENTS_SYNC_DRIVER_ABOUT_SYNC_UTIL_H_

-#include "base/memory/scoped_ptr.h"

+#include <memory>

#include "components/version_info/version_info.h"

class SigninManagerBase;

@@ -65,7 +66,7 @@ extern const char kUpdate[];

// This function returns a DictionaryValue which contains all the information

// required to populate the 'About' tab of about:sync.

// Note that |service| may be NULL.

-scoped_ptr<base::DictionaryValue> ConstructAboutInformation(

+std::unique_ptr<base::DictionaryValue> ConstructAboutInformation(

sync_driver::SyncService* service,

SigninManagerBase* signin,

version_info::Channel channel);