components/sync_driver/generic_change_processor_factory.h - Issue 1907683003: Convert //components/sync_driver from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/generic_change_processor_factory.h

Issue 1907683003: Convert //components/sync_driver from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/sync_driver/fake_sync_client.h ('K') | « components/sync_driver/generic_change_processor.cc ('k') | components/sync_driver/generic_change_processor_factory.cc » ('j') | components/sync_driver/glue/browser_thread_model_worker_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/generic_change_processor_factory.h

diff --git a/components/sync_driver/generic_change_processor_factory.h b/components/sync_driver/generic_change_processor_factory.h

index 2f49274bf88cd4e396212bebfce750ac6d01d5a5..aa19fb0862872716b49dc7210d49fcf7cada77a4 100644

--- a/components/sync_driver/generic_change_processor_factory.h

+++ b/components/sync_driver/generic_change_processor_factory.h

@@ -5,8 +5,9 @@

#ifndef COMPONENTS_SYNC_DRIVER_GENERIC_CHANGE_PROCESSOR_FACTORY_H_

#define COMPONENTS_SYNC_DRIVER_GENERIC_CHANGE_PROCESSOR_FACTORY_H_

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "sync/internal_api/public/base/model_type.h"

@@ -36,7 +37,7 @@ class GenericChangeProcessorFactory {

public:

GenericChangeProcessorFactory();

virtual ~GenericChangeProcessorFactory();

- virtual scoped_ptr<GenericChangeProcessor> CreateGenericChangeProcessor(

+ virtual std::unique_ptr<GenericChangeProcessor> CreateGenericChangeProcessor(

syncer::ModelType type,

syncer::UserShare* user_share,

DataTypeErrorHandler* error_handler,