Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: net/quic/quic_header_list_test.cc

Issue 1907683002: Adds a DebugString() method to QuicHeaderList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_header_list.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_header_list_test.cc
diff --git a/net/quic/quic_header_list_test.cc b/net/quic/quic_header_list_test.cc
index bd4e560b57885042679a0a42767565863871fdbb..94f824972e7f7805640d5efd7f0fb1db05286518 100644
--- a/net/quic/quic_header_list_test.cc
+++ b/net/quic/quic_header_list_test.cc
@@ -16,11 +16,7 @@ TEST(QuicHeaderListTest, OnHeader) {
headers.OnHeader("april", "fools");
headers.OnHeader("beep", "");
- std::string accumulator;
- for (const auto& p : headers) {
- accumulator.append("(" + p.first + ", " + p.second + ") ");
- }
- EXPECT_EQ("(foo, bar) (april, fools) (beep, ) ", accumulator);
+ EXPECT_EQ("{ foo=bar, april=fools, beep=, }", headers.DebugString());
}
// This test verifies that QuicHeaderList is copyable and assignable.
@@ -33,17 +29,8 @@ TEST(QuicHeaderListTest, IsCopyableAndAssignable) {
QuicHeaderList headers2(headers);
QuicHeaderList headers3 = headers;
- std::string accumulator;
- for (const auto& p : headers2) {
- accumulator.append("(" + p.first + ", " + p.second + ") ");
- }
- EXPECT_EQ("(foo, bar) (april, fools) (beep, ) ", accumulator);
-
- accumulator.clear();
- for (const auto& p : headers3) {
- accumulator.append("(" + p.first + ", " + p.second + ") ");
- }
- EXPECT_EQ("(foo, bar) (april, fools) (beep, ) ", accumulator);
+ EXPECT_EQ("{ foo=bar, april=fools, beep=, }", headers2.DebugString());
+ EXPECT_EQ("{ foo=bar, april=fools, beep=, }", headers3.DebugString());
}
} // namespace net
« no previous file with comments | « net/quic/quic_header_list.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698