Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1907653002: WebUI: allow target="_blank" by default in parseHtmlSubset(). (Closed)

Created:
4 years, 8 months ago by Dan Beam
Modified:
4 years, 8 months ago
Reviewers:
tommycli
CC:
chromium-reviews, oshima+watch_chromium.org, Moe
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: allow target="_blank" by default in parseHtmlSubset(). This code was originally written for the New Tab Page[1], which should always be clobbered by a link click. The NTP no longer shows promos (which is why it used parseHtmlSubset()), and other WebUI pages like settings use target="_blank", so allow target="_blank" globally. R=tommycli@chromium.org BUG=605226 [1] https://codereview.chromium.org/1759007, https://crbug.com/29084 Committed: https://crrev.com/744f96d502ab03be5baf879e563cfc01cb336c4a Cr-Commit-Position: refs/heads/master@{#388629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -27 lines) Patch
M chrome/test/data/webui/parse_html_subset_test.html View 4 chunks +21 lines, -21 lines 0 comments Download
M ui/webui/resources/js/parse_html_subset.js View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Dan Beam
4 years, 8 months ago (2016-04-20 21:25:59 UTC) #2
tommycli
lgtm
4 years, 8 months ago (2016-04-20 22:19:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907653002/1
4 years, 8 months ago (2016-04-20 22:25:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/215945)
4 years, 8 months ago (2016-04-20 23:25:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907653002/1
4 years, 8 months ago (2016-04-20 23:43:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 00:25:18 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:28:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/744f96d502ab03be5baf879e563cfc01cb336c4a
Cr-Commit-Position: refs/heads/master@{#388629}

Powered by Google App Engine
This is Rietveld 408576698