Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1907633002:
Update distribution on the nodes involved in click (Closed)
|
Created:
4 years, 8 months ago by Navid Zolghadr Modified:
4 years, 7 months ago CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate distribution on the nodes involved in click
Calling updateDistribution function on the nodes
that are involved in a click (both mouseup and
mousedown nodes) to prevent dchecks when calculating
their parents
BUG=604981
Committed: https://crrev.com/e2ee0b0adadd714acbe41ec0e3279243a6885236
Cr-Commit-Position: refs/heads/master@{#389906}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Applying comments #Messages
Total messages: 21 (7 generated)
nzolghadr@chromium.org changed reviewers: + dtapuska@chromium.org, mustaq@chromium.org
lgtm
https://codereview.chromium.org/1907633002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/1907633002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/input/EventHandler.cpp:1466: if (m_clickNode != mev.innerNode() This isn't the same code as before.. What happens if m_clickNode == mev.innerNode() don't we need to still update the distribution? I understood the issue reported against this was that m_clickNode and mev.innerNode weren't equal and both needed to be updated the distribution. But it seems when they are the same we avoid updating the distribution as well.
On 2016/04/21 16:08:28, dtapuska wrote: > https://codereview.chromium.org/1907633002/diff/1/third_party/WebKit/Source/c... > File third_party/WebKit/Source/core/input/EventHandler.cpp (right): > > https://codereview.chromium.org/1907633002/diff/1/third_party/WebKit/Source/c... > third_party/WebKit/Source/core/input/EventHandler.cpp:1466: if (m_clickNode != > mev.innerNode() > This isn't the same code as before.. > > What happens if m_clickNode == mev.innerNode() don't we need to still update the > distribution? > > I understood the issue reported against this was that m_clickNode and > mev.innerNode weren't equal and both needed to be updated the distribution. > > But it seems when they are the same we avoid updating the distribution as well. Can we add a layout test for this case? Then at least we should hit the assert on the debug try bots
ptal. I applied the comment regarding the code. But I couldn't create a test to repo this problem. I don't seem to have achieved the full knowledge of these shadow dom in the code to be able to see through. Only having the nodes in different document or only creating a simple shadow dome didn't repo the problem.
On 2016/04/22 15:17:27, Navid Zolghadr wrote: > ptal. I applied the comment regarding the code. > > But I couldn't create a test to repo this problem. I don't seem to have achieved > the full knowledge of these shadow dom in the code to be able to see through. > Only having the nodes in different document or only creating a simple shadow > dome didn't repo the problem. lgtm
The CQ bit was checked by nzolghadr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mustaq@chromium.org Link to the patchset: https://codereview.chromium.org/1907633002/#ps20001 (title: "Applying comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907633002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
nzolghadr@chromium.org changed reviewers: + bokan@chromium.org
bokan@chromium.org: Please review changes in hird_party/WebKit/Source/core/input/EventHandler.cpp
lgtm. Did we find out what updateDistribution does?
On 2016/04/26 20:15:24, bokan wrote: > lgtm. > > Did we find out what updateDistribution does? The other CL had nothing to do with updateDistribution to make me learn that. The limited stuff I was saying in the other CL was the stuff that I learned from this CL :). So basically nothing more than I already mentioned in the other CL.
The CQ bit was checked by nzolghadr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907633002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Update distribution on the nodes involved in click Calling updateDistribution function on the nodes that are involved in a click (both mouseup and mousedown nodes) to prevent dchecks when calculating their parents BUG=604981 ========== to ========== Update distribution on the nodes involved in click Calling updateDistribution function on the nodes that are involved in a click (both mouseup and mousedown nodes) to prevent dchecks when calculating their parents BUG=604981 Committed: https://crrev.com/e2ee0b0adadd714acbe41ec0e3279243a6885236 Cr-Commit-Position: refs/heads/master@{#389906} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e2ee0b0adadd714acbe41ec0e3279243a6885236 Cr-Commit-Position: refs/heads/master@{#389906} |
