sdk/lib/_internal/compiler/implementation/ssa/nodes.dart - Issue 190763013: Detect total switches to prevent type pollution by default cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 190763013: Detect total switches to prevent type pollution by default cases. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart b/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

index 774ab84a4384117b534b3d3d3ba1c4ae3aeb6b0b..e8884405003b1322ab98dbf25ada8881c3b20169 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

@@ -1716,6 +1716,12 @@ class HSwitch extends HControlFlow {

HBasicBlock get defaultTarget => block.successors.last;

+ /**

+ * Set to true if we statically know that the case statements

+ * are exhaustive wrt the range of the expression.

+ */

+ bool isTotal = false;

accept(HVisitor visitor) => visitor.visitSwitch(this);

String toString() => "HSwitch cases = $inputs";