sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart - Issue 190763013: Detect total switches to prevent type pollution by default cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

Issue 190763013: Detect total switches to prevent type pollution by default cases. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/ssa/optimize.dart ('K') | « sdk/lib/_internal/compiler/implementation/ssa/tracer.dart ('k') | tests/compiler/dart2js/switch_empty_default_test.dart » ('j') | tests/compiler/dart2js/switch_empty_default_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart b/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

index ed6852e719f9d405b8f3bfe74f5b819aff98c82b..bdaa18336c06ba84fa9d8c693ed417c73f57c7f3 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

@@ -610,6 +610,8 @@ class SsaValueRangeAnalyzer extends HBaseVisitor implements OptimizationPhase {

// that the graph does not get polluted with these instructions

// only necessary for this phase.

removeRangeConversion();

+ // TODO(herhut): Find a better way to pass around ranges

+ (compiler.backend as JavaScriptBackend).optimizer.ranges = ranges;

karlklose 2014/03/12 14:43:45 Do you want the explicit type check here? Conside

herhut 2014/03/13 13:27:45 Done.

}

void removeRangeConversion() {