Detect total switches to prevent type pollution by default cases.

sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaCodeGeneratorTask extends CompilerTask {
 
   final JavaScriptBackend backend;
 
@@ skipping 638 matching lines @@
     List<js.SwitchClause> cases = <js.SwitchClause>[];
     HSwitch switchInstruction = info.expression.end.last;
     List<HInstruction> inputs = switchInstruction.inputs;
     List<HBasicBlock> successors = switchInstruction.block.successors;
 
     js.Block oldContainer = currentContainer;
     for (int inputIndex = 1, statementIndex = 0;
          inputIndex < inputs.length;
          statementIndex++) {
       HBasicBlock successor = successors[inputIndex - 1];
-      do {
-        visit(inputs[inputIndex]);
-        currentContainer = new js.Block.empty();
-        cases.add(new js.Case(pop(), currentContainer));
-        inputIndex++;
-      } while ((successors[inputIndex - 1] == successor)
-               && (inputIndex < inputs.length));
+      // If liveness analysis has figured out that this case is dead,
+      // omit the code for it.
+      if (successor.isLive) {
+        do {
+          visit(inputs[inputIndex]);
+          currentContainer = new js.Block.empty();
+          cases.add(new js.Case(pop(), currentContainer));
+          inputIndex++;
+        } while ((successors[inputIndex - 1] == successor)
+                 && (inputIndex < inputs.length));
 
-      generateStatements(info.statements[statementIndex]);
+        generateStatements(info.statements[statementIndex]);
+      } else {
+        // Skip all the case statements that belong to this
+        // block.
+        while ((successors[inputIndex - 1] == successor)
+              && (inputIndex < inputs.length)) {
+          ++inputIndex;
+        }
+      }
     }
 
-    currentContainer = new js.Block.empty();
-    cases.add(new js.Default(currentContainer));
-    generateStatements(info.statements.last);
+    // If the default case is dead, we omit it. Likewise, if it is an
+    // empty block, we omit it, too.
+    if (info.statements.last.start.isLive) {
+      currentContainer = new js.Block.empty();
+      generateStatements(info.statements.last);

[karlklose, 2014/03/12 14:43:45]

Why did you change the order here?

[herhut, 2014/03/13 13:27:45]

I need to generate the statements to see whether the case will be empty. I did
not want to first add the case to the list of cases and then remove it again, so
I delay adding it until after statement generation.

+      if (currentContainer.statements.isNotEmpty)

[karlklose, 2014/03/12 14:43:45]

Please use curly braces.

[herhut, 2014/03/13 13:27:45]

Done.

+        cases.add(new js.Default(currentContainer));
+    }
 
     currentContainer = oldContainer;
 
     js.Statement result = new js.Switch(key, cases);
     pushStatement(wrapIntoLabels(result, info.labels));
     return true;
   }
 
   bool visitSequenceInfo(HStatementSequenceInformation info) {
     return false;
@@ skipping 1978 matching lines @@
     if (left.isConstantNull() || right.isConstantNull() ||
         (left.isPrimitive(compiler) &&
          left.instructionType == right.instructionType)) {
       return '==';
     }
     return null;
   } else {
     return '===';
   }
 }