Source/core/animation/ElementAnimation.idl - Issue 190763007: [WIP] Web Animations API: Constructing an Animation from partial keyframes throws a JS exception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/ElementAnimation.idl

Issue 190763007: [WIP] Web Animations API: Constructing an Animation from partial keyframes throws a JS exception (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Replace manual checks with check for dependsOnUnderlyingValue Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/ElementAnimation.idl

diff --git a/Source/core/animation/ElementAnimation.idl b/Source/core/animation/ElementAnimation.idl

index e5c5137854939fac5adad3b4820e86d63dd63989..61ded2ec018ee815406681220b30bfb229b381c0 100644

--- a/Source/core/animation/ElementAnimation.idl

+++ b/Source/core/animation/ElementAnimation.idl

@@ -31,7 +31,7 @@

[

RuntimeEnabled=WebAnimationsAPI,

] partial interface Element {

- Animation animate(sequence<Dictionary> keyframes, Dictionary timingInput);

- Animation animate(sequence<Dictionary> keyframes, double timingInput);

- Animation animate(sequence<Dictionary> keyframes);

+ [RaisesException] Animation animate(sequence<Dictionary> keyframes, Dictionary timingInput);

+ [RaisesException] Animation animate(sequence<Dictionary> keyframes, double timingInput);

+ [RaisesException] Animation animate(sequence<Dictionary> keyframes);

};

« no previous file with comments | « Source/core/animation/ElementAnimation.h ('k') | Source/core/animation/KeyframeEffectModel.h » ('j') | no next file with comments »