Source/core/animation/EffectInput.h - Issue 190763007: [WIP] Web Animations API: Constructing an Animation from partial keyframes throws a JS exception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/EffectInput.h

Issue 190763007: [WIP] Web Animations API: Constructing an Animation from partial keyframes throws a JS exception (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Replace manual checks with check for dependsOnUnderlyingValue Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/EffectInput.h

diff --git a/Source/core/animation/EffectInput.h b/Source/core/animation/EffectInput.h

index 0d316f79a6ca4c9600e182b29f0af577b236242a..4a73e45be03a4aa94aa495491fa925dea5ca4525 100644

--- a/Source/core/animation/EffectInput.h

+++ b/Source/core/animation/EffectInput.h

@@ -13,10 +13,11 @@ namespace WebCore {

class AnimationEffect;

class Dictionary;

class Element;

+class ExceptionState;

class EffectInput {

public:

- static PassRefPtrWillBeRawPtr<AnimationEffect> convert(Element*, const Vector<Dictionary>& keyframeDictionaryVector, bool unsafe = false);

+ static PassRefPtrWillBeRawPtr<AnimationEffect> convert(Element*, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState&, bool unsafe = false);

};

} // namespace WebCore

« no previous file with comments | « Source/core/animation/AnimationTest.cpp ('k') | Source/core/animation/EffectInput.cpp » ('j') | no next file with comments »