Source/core/animation/Animation.h - Issue 190763007: [WIP] Web Animations API: Constructing an Animation from partial keyframes throws a JS exception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/Animation.h

Issue 190763007: [WIP] Web Animations API: Constructing an Animation from partial keyframes throws a JS exception (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Replace manual checks with check for dependsOnUnderlyingValue Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/web-animations-api/element-animate-list-of-keyframes-expected.txt ('k') | Source/core/animation/Animation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/Animation.h

diff --git a/Source/core/animation/Animation.h b/Source/core/animation/Animation.h

index abc1be35e82ba28cab42075d6a46bb3f3c48596c..b61b4b987d2afb6e7f23364b53def52635bacdc6 100644

--- a/Source/core/animation/Animation.h

+++ b/Source/core/animation/Animation.h

@@ -40,8 +40,9 @@

namespace WebCore {

-class Element;

class Dictionary;

+class Element;

+class ExceptionState;

class Animation FINAL : public TimedItem {

@@ -53,9 +54,9 @@ public:

static PassRefPtr<Animation> create(Element*, PassRefPtrWillBeRawPtr<AnimationEffect>, const Dictionary& timingInputDictionary);

static PassRefPtr<Animation> create(Element*, PassRefPtrWillBeRawPtr<AnimationEffect>, double duration);

static PassRefPtr<Animation> create(Element*, PassRefPtrWillBeRawPtr<AnimationEffect>);

- static PassRefPtr<Animation> create(Element*, const Vector<Dictionary>& keyframeDictionaryVector, const Dictionary& timingInputDictionary);

- static PassRefPtr<Animation> create(Element*, const Vector<Dictionary>& keyframeDictionaryVector, double duration);

- static PassRefPtr<Animation> create(Element*, const Vector<Dictionary>& keyframeDictionaryVector);

+ static PassRefPtr<Animation> create(Element*, const Vector<Dictionary>& keyframeDictionaryVector, const Dictionary& timingInputDictionary, ExceptionState&);

+ static PassRefPtr<Animation> create(Element*, const Vector<Dictionary>& keyframeDictionaryVector, double duration, ExceptionState&);

+ static PassRefPtr<Animation> create(Element*, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState&);

// FIXME: Move all of these setter methods out of Animation,

// possibly into a new class (TimingInput?).