Source/core/animation/ElementAnimation.h - Issue 190763007: [WIP] Web Animations API: Constructing an Animation from partial keyframes throws a JS exception

Side by Side Diff: Source/core/animation/ElementAnimation.h

Issue 190763007: [WIP] Web Animations API: Constructing an Animation from partial keyframes throws a JS exception (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Replace manual checks with check for dependsOnUnderlyingValue Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/animation/EffectInput.cpp ('k') | Source/core/animation/ElementAnimation.idl » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 static Animation* animate(Element& element, PassRefPtrWillBeRawPtr<Animation Effect> effect, double duration)	52 static Animation* animate(Element& element, PassRefPtrWillBeRawPtr<Animation Effect> effect, double duration)

53 {	53 {

54 return animateInternal(element, effect, TimingInput::convert(duration));	54 return animateInternal(element, effect, TimingInput::convert(duration));

55 }	55 }

56	56

57 static Animation* animate(Element& element, PassRefPtrWillBeRawPtr<Animation Effect> effect)	57 static Animation* animate(Element& element, PassRefPtrWillBeRawPtr<Animation Effect> effect)

58 {	58 {

59 return animateInternal(element, effect, Timing());	59 return animateInternal(element, effect, Timing());

60 }	60 }

61	61

62 static Animation* animate(Element& element, const Vector<Dictionary>& keyfra meDictionaryVector, const Dictionary& timingInputDictionary)	62 static Animation* animate(Element& element, const Vector<Dictionary>& keyfra meDictionaryVector, const Dictionary& timingInputDictionary, ExceptionState& exc eptionState)

63 {	63 {

64 return animateInternal(element, EffectInput::convert(&element, keyframeD ictionaryVector), TimingInput::convert(timingInputDictionary));	64 return animateInternal(element, EffectInput::convert(&element, keyframeD ictionaryVector, exceptionState), TimingInput::convert(timingInputDictionary));

65 }	65 }

66	66

67 static Animation* animate(Element& element, const Vector<Dictionary>& keyfra meDictionaryVector, double duration)	67 static Animation* animate(Element& element, const Vector<Dictionary>& keyfra meDictionaryVector, double duration, ExceptionState& exceptionState)

68 {	68 {

69 return animateInternal(element, EffectInput::convert(&element, keyframeD ictionaryVector), TimingInput::convert(duration));	69 return animateInternal(element, EffectInput::convert(&element, keyframeD ictionaryVector, exceptionState), TimingInput::convert(duration));

70 }	70 }

71	71

72 static Animation* animate(Element& element, const Vector<Dictionary>& keyfra meDictionaryVector)	72 static Animation* animate(Element& element, const Vector<Dictionary>& keyfra meDictionaryVector, ExceptionState& exceptionState)

73 {	73 {

74 return animateInternal(element, EffectInput::convert(&element, keyframeD ictionaryVector), Timing());	74 return animateInternal(element, EffectInput::convert(&element, keyframeD ictionaryVector, exceptionState), Timing());

75 }	75 }

76	76

77 private:	77 private:

78 static Animation* animateInternal(Element& element, PassRefPtrWillBeRawPtr<A nimationEffect> effect, const Timing& timing)	78 static Animation* animateInternal(Element& element, PassRefPtrWillBeRawPtr<A nimationEffect> effect, const Timing& timing)

79 {	79 {

80 ASSERT(RuntimeEnabledFeatures::webAnimationsAPIEnabled());	80 ASSERT(RuntimeEnabledFeatures::webAnimationsAPIEnabled());

81 RefPtr<Animation> animation = Animation::create(&element, effect, timing );	81 RefPtr<Animation> animation = Animation::create(&element, effect, timing );

82 element.document().timeline().play(animation.get());	82 element.document().timeline().play(animation.get());

83 return animation.get();	83 return animation.get();

84 }	84 }

85 };	85 };

86	86

87 } // namespace WebCore	87 } // namespace WebCore

88	88

89 #endif // ElementAnimation_h	89 #endif // ElementAnimation_h

OLD	NEW