Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/web-animations-api/animation-constructor.html

Issue 190763007: [WIP] Web Animations API: Constructing an Animation from partial keyframes throws a JS exception (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add FIXME for keyframes at 0 and 1. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/web-animations-api/element-animate-list-of-keyframes.html » ('j') | Source/core/animation/EffectInput.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <script src="../resources/testharness.js"></script> 2 <script src="../resources/testharness.js"></script>
3 <script src="../resources/testharnessreport.js"></script> 3 <script src="../resources/testharnessreport.js"></script>
4 4
5 <body> 5 <body>
6 <div id='e'></div> 6 <div id='e'></div>
7 </body> 7 </body>
8 8
9 <script> 9 <script>
10 var element = document.getElementById('e'); 10 var element = document.getElementById('e');
11 11
12 var animationWithTimingObject = new Animation(element, 12 test(function() {
13 [{opacity: '1', offset: 0}, 13 var animationWithTimingObject = new Animation(element,
14 {opacity: '0', offset: 1}], 14 [{opacity: '1', offset: 0},
15 {duration: 2, iterations: 5}); 15 {opacity: '0', offset: 1}],
16 {duration: 2, iterations: 5});
16 17
17 var animationWithDuration = new Animation(element,
18 [{opacity: '1', offset: 0},
19 {opacity: '0', offset: 1}],
20 2);
21
22 var animationNoTiming = new Animation(element,
23 [{opacity: '1', offset: 0},
24 {opacity: '0', offset: 1}]);
25
26 test(function() {
27 assert_false(animationWithTimingObject == undefined); 18 assert_false(animationWithTimingObject == undefined);
28 assert_equals(animationWithTimingObject.constructor, Animation); 19 assert_equals(animationWithTimingObject.constructor, Animation);
29 }, 'Calling new Animation() with a timing object input should create an animatio n.'); 20 }, 'Calling new Animation() with a timing object input should create an animatio n.');
30 21
31 test(function() { 22 test(function() {
23 var animationWithDuration = new Animation(element,
24 [{opacity: '1', offset: 0},
25 {opacity: '0', offset: 1}],
26 2);
27
32 assert_false(animationWithDuration == undefined); 28 assert_false(animationWithDuration == undefined);
33 assert_equals(animationWithDuration.constructor, Animation); 29 assert_equals(animationWithDuration.constructor, Animation);
34 }, 'Calling new Animation() with a duration input should create an animation.'); 30 }, 'Calling new Animation() with a duration input should create an animation.');
35 31
36 test(function() { 32 test(function() {
33 var animationNoTiming = new Animation(element,
34 [{opacity: '1', offset: 0},
35 {opacity: '0', offset: 1}]);
36
37 assert_false(animationNoTiming == undefined); 37 assert_false(animationNoTiming == undefined);
38 assert_equals(animationNoTiming.constructor, Animation); 38 assert_equals(animationNoTiming.constructor, Animation);
39 }, 'Calling new Animation() with no timing input should create an animation.'); 39 }, 'Calling new Animation() with no timing input should create an animation.');
40 </script> 40
41 test(function() {
42 var partialKeyframes1 = [
43 {opacity: '1', color: 'red', offset: 0},
44 {opacity: '0', offset: 1}];
45 var partialKeyframes2 = [
46 {opacity: '1', color: 'red', offset: 0},
47 {opacity: '0', color: 'foo', offset: 1}];
48
49 assert_throws('NOT_SUPPORTED_ERR', function() { new Animation(element, parti alKeyframes1); });
50 assert_throws('NOT_SUPPORTED_ERR', function() { new Animation(element, parti alKeyframes2); });
51 }, 'Calling new Animation() with a mismatched keyframe property should throw a N otSupportedError.');
52
53 test(function() {
54 var validKeyframes = [
55 {opacity: '1', offset: 0},
56 {opacity: '0', offset: 1}];
57 var partialKeyframes1 = [
58 {opacity: '1', offset: 0.1},
59 {opacity: '0', offset: 1}];
60 var partialKeyframes2 = [
61 {opacity: '1', offset: 0.1},
62 {opacity: '0', offset: 0.2}];
63 var partialKeyframes3 = [
64 {opacity: '1', offset: 0.5},
65 {opacity: '0'}];
66
67 assert_not_equals(function() { new Animation(element, validKeyframes); }, un defined);
68 assert_throws('NOT_SUPPORTED_ERR', function() { new Animation(element, parti alKeyframes1); });
69 assert_throws('NOT_SUPPORTED_ERR', function() { new Animation(element, parti alKeyframes2); });
70 assert_throws('NOT_SUPPORTED_ERR', function() { new Animation(element, parti alKeyframes3); });
71 }, 'Calling animate() with specified offsets but no keframe for offset: 0 should throw a NotSupportedError.');
72
73 test(function() {
74 var partialKeyframes1 = [
75 {opacity: '1', offset: 0},
76 {opacity: '0', offset: 0.1}];
77
78 assert_throws('NOT_SUPPORTED_ERR', function() { new Animation(element, parti alKeyframes1); });
79 }, 'Calling animate() with specified offsets but no keyframe for offset: 1 shoul d throw a NotSupportedError.');
80 </script>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/web-animations-api/element-animate-list-of-keyframes.html » ('j') | Source/core/animation/EffectInput.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698