[WIP] Web Animations API: Constructing an Animation from partial keyframes throws a JS exception

Source/core/animation/EffectInput.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 30 matching lines @@
 namespace WebCore {
 
 static bool checkDocumentAndRenderer(Element* element)
 {
     if (!element->inActiveDocument())
         return false;
     element->document().updateStyleIfNeeded();
     return element->renderer();
 }
 
-PassRefPtrWillBeRawPtr<AnimationEffect> EffectInput::convert(Element* element, const Vector<Dictionary>& keyframeDictionaryVector, bool unsafe)
+static bool hasPartialKeyframe(Vector<RefPtr<MutableStylePropertySet> > propertySetVector)
+{
+    HashCountedSet<CSSPropertyID> counter;
+    for (size_t i = 0; i < propertySetVector.size(); ++i) {
+        for (size_t j = 0; j < propertySetVector[i]->propertyCount(); ++j) {
+            CSSPropertyID property = propertySetVector[i]->propertyAt(j).id();
+            counter.add(property);
+        }
+    }
+    for (HashCountedSet<CSSPropertyID>::iterator iterator = counter.begin(); iterator != counter.end(); ++iterator) {
+        if (iterator->value == 1)
+            return true;
+    }
+    return false;
+}

[shans, 2014/03/10 23:28:40]

This won't pick up cases like:
element.animate(
  [{opacity: '0', offset: 0},
   {opacity: '1', offset: 0.5}], 1);

[rjwright, 2014/03/10 23:35:37]

It is meant to?

[rjwright, 2014/03/11 01:48:42]

Done.

+
+PassRefPtrWillBeRawPtr<AnimationEffect> EffectInput::convert(Element* element, const Vector<Dictionary>& keyframeDictionaryVector,  ExceptionState& exceptionState, bool unsafe)
 {
     // FIXME: This test will not be neccessary once resolution of keyframe values occurs at
     // animation application time.
     if (!unsafe && !checkDocumentAndRenderer(element))
         return nullptr;
 
     // FIXME: Move this code into KeyframeEffectModel, it will be used by the IDL constructor for that class.
     KeyframeEffectModel::KeyframeVector keyframes;
     Vector<RefPtr<MutableStylePropertySet> > propertySetVector;
 
@@ skipping 34 matching lines @@
             // KeyframeEffectModel, store input keyframes and implement getFrames.
             if (id == CSSPropertyInvalid || !CSSAnimations::isAnimatableProperty(id))
                 continue;
 
             String value;
             keyframeDictionaryVector[i].get(property, value);
             propertySet->setProperty(id, value);
         }
     }
 
+    // FIXME: Web Animations can't yet handle keyframe sets where a property appears in only one keyframe (called "partial keyframes").
+    // This check can be removed once support for such inputs is added.
+    if (hasPartialKeyframe(propertySetVector))
+        exceptionState.throwDOMException(NotSupportedError, "Keyframe effect contains properties that appear in only one keyframe.");
+
     // FIXME: Replace this with code that just parses, when that code is available.
     return StyleResolver::createKeyframeEffectModel(*element, propertySetVector, keyframes);
 }
 
 } // namespace WebCore