GN flag to fail for unused build args.

GN flag to fail for unused build args.

This flag was requested by ChromeOS so their bot can notice if their build's args gets out of sync with Chrome's build files.

Also removes printing all possible build args on this error because we've gotten so many that's it's several screen-fulls of text and you can't even read the error.

BUG=605199
Committed: https://crrev.com/12985c01ad47c1366920941f837fc2f323480c0e
Cr-Commit-Position: refs/heads/master@{#389407}

[brettw, 2016-04-20 20:10:04]

Description was changed from

==========
GN flag to fail for unused build args.

This flag was requested by ChromeOS so their bot can notice if their build's
args gets out of sync with Chrome's build files.

BUG=605199
==========

to

==========
GN flag to fail for unused build args.

This flag was requested by ChromeOS so their bot can notice if their build's
args gets out of sync with Chrome's build files.

Also removes printing all possible build args on this error because we've gotten
so many that's it's several screen-fulls of text and you can't even read the
error.

BUG=605199
==========

[brettw, 2016-04-20 20:10:05]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-04-20 20:10:09]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 20:10:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907613002/1

[commit-bot: I haz the power, 2016-04-20 21:18:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 21:18:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-04-20 22:03:35]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 22:04:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907613002/1

[commit-bot: I haz the power, 2016-04-20 23:14:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 23:14:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-04-20 23:37:31]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 23:38:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907613002/1

[commit-bot: I haz the power, 2016-04-21 00:28:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 00:28:53]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-04-23 01:27:17]

lgtm though I'd prefer it if we failed by default (as noted below).

https://codereview.chromium.org/1907613002/diff/1/tools/gn/setup.cc
File tools/gn/setup.cc (right):

https://codereview.chromium.org/1907613002/diff/1/tools/gn/setup.cc#newcode342
tools/gn/setup.cc:342: return true;
I actually feel (reasonably strongly) that we should fail on unused args by
default, and have the switch *disable* that behavior, at least until we get a
lot more feedback that this is unworkable.

Or, at least, I would say that should be the default and then configurable per
repo via the dotfile.

But, I don't feel so strongly about this that I won't approve this CL.

[brettw, 2016-04-24 17:36:09]

On 2016/04/23 01:27:17, Dirk Pranke wrote:
> lgtm though I'd prefer it if we failed by default (as noted below).

We can re-evaluate that in the future if the bots seem to be happy running in
this mode.

[brettw, 2016-04-24 17:52:40]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-04-24 17:52:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907613002/1

[commit-bot: I haz the power, 2016-04-24 19:03:31]

Description was changed from

==========
GN flag to fail for unused build args.

This flag was requested by ChromeOS so their bot can notice if their build's
args gets out of sync with Chrome's build files.

Also removes printing all possible build args on this error because we've gotten
so many that's it's several screen-fulls of text and you can't even read the
error.

BUG=605199
==========

to

==========
GN flag to fail for unused build args.

This flag was requested by ChromeOS so their bot can notice if their build's
args gets out of sync with Chrome's build files.

Also removes printing all possible build args on this error because we've gotten
so many that's it's several screen-fulls of text and you can't even read the
error.

BUG=605199
==========

[commit-bot: I haz the power, 2016-04-24 19:03:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-24 19:05:00]

Description was changed from

==========
GN flag to fail for unused build args.

This flag was requested by ChromeOS so their bot can notice if their build's
args gets out of sync with Chrome's build files.

Also removes printing all possible build args on this error because we've gotten
so many that's it's several screen-fulls of text and you can't even read the
error.

BUG=605199
==========

to

==========
GN flag to fail for unused build args.

This flag was requested by ChromeOS so their bot can notice if their build's
args gets out of sync with Chrome's build files.

Also removes printing all possible build args on this error because we've gotten
so many that's it's several screen-fulls of text and you can't even read the
error.

BUG=605199

Committed: https://crrev.com/12985c01ad47c1366920941f837fc2f323480c0e
Cr-Commit-Position: refs/heads/master@{#389407}
==========

[commit-bot: I haz the power, 2016-04-24 19:05:01]

Patchset 1 (id:??) landed as
https://crrev.com/12985c01ad47c1366920941f837fc2f323480c0e
Cr-Commit-Position: refs/heads/master@{#389407}

[Nico, 2016-06-13 11:35:19]

On 2016/04/23 01:27:17, Dirk Pranke wrote:
> lgtm though I'd prefer it if we failed by default (as noted below).
> 
> https://codereview.chromium.org/1907613002/diff/1/tools/gn/setup.cc
> File tools/gn/setup.cc (right):
> 
> https://codereview.chromium.org/1907613002/diff/1/tools/gn/setup.cc#newcode342
> tools/gn/setup.cc:342: return true;
> I actually feel (reasonably strongly) that we should fail on unused args by
> default, and have the switch *disable* that behavior, at least until we get a
> lot more feedback that this is unworkable.
> 
> Or, at least, I would say that should be the default and then configurable per
> repo via the dotfile.
> 
> But, I don't feel so strongly about this that I won't approve this CL.

I too think this should be an error, not a warning. (This just being a warning
caused us to miss that mb sets v8_target_cpu instead of v8_target_arch until
machenbach happened to notice that in
https://bugs.chromium.org/p/chromium/issues/detail?id=619503#c1)