Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1907603003: tools/android/loading: rm testdata/rollingstone.trace.gz (Closed)

Created:
4 years, 8 months ago by gabadie
Modified:
4 years, 8 months ago
Reviewers:
Benoit L
CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/android/loading: rm testdata/rollingstone.trace.gz ./testdata/rollingstone.trace.gz has become out of date, causing ./loading_trace_analyzer_unittest.py to fail. This CL removes both files to get ./run_tests passing again. BUG=582080 Committed: https://crrev.com/c799dc85bde528d0bbf39e5e432a6ecb8bb22eca Cr-Commit-Position: refs/heads/master@{#388728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59 lines) Patch
D tools/android/loading/loading_trace_analyzer_unittest.py View 1 chunk +0 lines, -59 lines 0 comments Download
D tools/android/loading/testdata/rollingstone.trace.gz View Binary file 0 comments Download

Messages

Total messages: 9 (3 generated)
gabadie
Good morning Benoit, =) This CL remove the ./run_tests's failing test because was using an ...
4 years, 8 months ago (2016-04-21 07:56:53 UTC) #2
Benoit L
On 2016/04/21 07:56:53, gabadie wrote: > Good morning Benoit, =) > > This CL remove ...
4 years, 8 months ago (2016-04-21 08:03:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907603003/1
4 years, 8 months ago (2016-04-21 08:19:26 UTC) #5
gabadie
On 2016/04/21 08:03:56, Benoit L wrote: > On 2016/04/21 07:56:53, gabadie wrote: > > Good ...
4 years, 8 months ago (2016-04-21 08:19:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 08:54:23 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:32:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c799dc85bde528d0bbf39e5e432a6ecb8bb22eca
Cr-Commit-Position: refs/heads/master@{#388728}

Powered by Google App Engine
This is Rietveld 408576698