Support the non-native (RGBA/BGRA) swizzle

Support the non-native (RGBA/BGRA) swizzle

BUG=skia:4456
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1907593004

Committed: https://skia.googlesource.com/skia/+/34e0ec40b10320765d4a4432f56e090556f9c75e

[msarett, 2016-04-20 22:52:11]

Description was changed from

==========
Support the non-native (RGBA/BGRA) swizzle

BUG=skia:
==========

to

==========
Support the non-native (RGBA/BGRA) swizzle

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-04-22 19:07:54]

Description was changed from

==========
Support the non-native (RGBA/BGRA) swizzle

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Support the non-native (RGBA/BGRA) swizzle

BUG=skia:4456
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-04-22 19:08:07]

msarett@google.com changed reviewers:
+ scroggo@google.com

[scroggo, 2016-04-22 20:12:32]

lgtm

https://codereview.chromium.org/1907593004/diff/20001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1907593004/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:113: default:
Why is this necessary?

https://codereview.chromium.org/1907593004/diff/20001/src/codec/SkBmpStandard...
File src/codec/SkBmpStandardCodec.h (right):

https://codereview.chromium.org/1907593004/diff/20001/src/codec/SkBmpStandard...
src/codec/SkBmpStandardCodec.h:73: bool createColorTable(SkColorType colorType,
SkAlphaType alphaType, int* colorCount);
nit: It would be better to keep the signatures for these to be more similar.
(e.g. make RLE put color type first.)

https://codereview.chromium.org/1907593004/diff/20001/src/codec/SkPngCodec.cpp
File src/codec/SkPngCodec.cpp (right):

https://codereview.chromium.org/1907593004/diff/20001/src/codec/SkPngCodec.cp...
src/codec/SkPngCodec.cpp:92: bool SkPngCodec::decodePalette(bool premultiply,
SkColorType dstColorType, int* ctableCount) {
Should this be renamed to createColorTable, to be more consistent? And have a
similar param order as the others?

[msarett, 2016-04-22 20:25:23]

https://codereview.chromium.org/1907593004/diff/20001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1907593004/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:113: default:
On 2016/04/22 20:12:32, scroggo wrote:
> Why is this necessary?

We're not testing kNonNative mode for BRD, but now that it exists, we need to
handle it in the switch statement.

https://codereview.chromium.org/1907593004/diff/20001/src/codec/SkBmpStandard...
File src/codec/SkBmpStandardCodec.h (right):

https://codereview.chromium.org/1907593004/diff/20001/src/codec/SkBmpStandard...
src/codec/SkBmpStandardCodec.h:73: bool createColorTable(SkColorType colorType,
SkAlphaType alphaType, int* colorCount);
On 2016/04/22 20:12:32, scroggo wrote:
> nit: It would be better to keep the signatures for these to be more similar.
> (e.g. make RLE put color type first.)

sgtm

https://codereview.chromium.org/1907593004/diff/20001/src/codec/SkPngCodec.cpp
File src/codec/SkPngCodec.cpp (right):

https://codereview.chromium.org/1907593004/diff/20001/src/codec/SkPngCodec.cp...
src/codec/SkPngCodec.cpp:92: bool SkPngCodec::decodePalette(bool premultiply,
SkColorType dstColorType, int* ctableCount) {
On 2016/04/22 20:12:32, scroggo wrote:
> Should this be renamed to createColorTable, to be more consistent? And have a
> similar param order as the others?

Yes sgtm.

[msarett, 2016-04-22 20:25:28]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 20:25:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907593004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907593004/40001

[commit-bot: I haz the power, 2016-04-22 20:27:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 20:27:03]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[msarett, 2016-04-22 20:41:24]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 20:41:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907593004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907593004/80001

[commit-bot: I haz the power, 2016-04-22 20:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 20:42:39]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[msarett, 2016-04-22 20:49:18]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[msarett, 2016-04-22 20:49:27]

The CQ bit was unchecked by msarett@google.com

[msarett, 2016-04-22 20:49:48]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 20:49:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907593004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907593004/100001

[commit-bot: I haz the power, 2016-04-22 20:51:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 20:51:09]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[msarett, 2016-04-22 20:58:00]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 20:58:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907593004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907593004/120001

[commit-bot: I haz the power, 2016-04-22 20:59:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 20:59:39]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[msarett, 2016-04-22 23:03:35]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 23:03:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907593004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907593004/140001

[msarett, 2016-04-22 23:03:45]

Patchset #4 (id:60001) has been deleted

[msarett, 2016-04-22 23:04:29]

Patchset #5 (id:100001) has been deleted

[msarett, 2016-04-22 23:04:41]

Patchset #5 (id:120001) has been deleted

[commit-bot: I haz the power, 2016-04-22 23:05:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 23:05:55]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[msarett, 2016-04-22 23:12:18]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[msarett, 2016-04-22 23:12:24]

Patchset #5 (id:140001) has been deleted

[commit-bot: I haz the power, 2016-04-22 23:12:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907593004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907593004/160001

[commit-bot: I haz the power, 2016-04-22 23:25:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 23:25:16]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-04-22 23:26:18]

The CQ bit was checked by msarett@google.com

[msarett, 2016-04-22 23:26:19]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1907593004/#ps160001
(title: "Multiple bug fixes")

[commit-bot: I haz the power, 2016-04-22 23:26:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907593004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907593004/160001

[commit-bot: I haz the power, 2016-04-22 23:27:27]

Description was changed from

==========
Support the non-native (RGBA/BGRA) swizzle

BUG=skia:4456
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Support the non-native (RGBA/BGRA) swizzle

BUG=skia:4456
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/34e0ec40b10320765d4a4432f56e090556f9c75e
==========

[commit-bot: I haz the power, 2016-04-22 23:27:28]

Committed patchset #5 (id:160001) as
https://skia.googlesource.com/skia/+/34e0ec40b10320765d4a4432f56e090556f9c75e