Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1907593003:
Fix build error when USE_OZONE is undefined (Closed)
|
Created:
4 years, 8 months ago by victorhsieh0 Modified:
4 years, 8 months ago CC:
chromium-reviews, posciak+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix build error when USE_OZONE is undefined
Not sure this is correct behavior, but this should make the build green.
BUG=b/27779397,574241
TEST=ninja
Committed: https://crrev.com/a586e644f9670115bda03981e931d91defb1a607
Cr-Commit-Position: refs/heads/master@{#388627}
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
victorhsieh@google.com changed reviewers: + dalecurtis@chromium.org, sandersd@chromium.org
victorhsieh@google.com changed reviewers: + jbauman@chromium.org
PTAL This should fix arm-generic-chromium-pfq and nyan-chrome-pfq, although I'm not sure about the correctness.
Description was changed from ========== Fix build error when USE_OZONE is undefined Not sure this is correct behavior, but this should make the build green. BUG=b/27779397,574241 TEST=ninja ========== to ========== Fix build error when USE_OZONE is undefined Not sure this is correct behavior, but this should make the build green. BUG=b/27779397,574241 TEST=ninja ==========
sandersd@chromium.org changed reviewers: + posciak@chromium.org - sandersd@chromium.org
On 2016/04/20 20:50:47, victorhsieh0 wrote: > PTAL > > This should fix arm-generic-chromium-pfq and nyan-chrome-pfq, although I'm not > sure about the correctness. => posciak@ to review.
On 2016/04/20 20:57:33, sandersd wrote: > On 2016/04/20 20:50:47, victorhsieh0 wrote: > > PTAL > > > > This should fix arm-generic-chromium-pfq and nyan-chrome-pfq, although I'm not > > sure about the correctness. > > => posciak@ to review. (It should be safe to TBR this one.)
sandersd@chromium.org changed reviewers: + sandersd@chromium.org
I'll go ahead and RS LGTM since it looks like you're not a committer.
victorhsieh@chromium.org changed reviewers: + victorhsieh@chromium.org
wrong account.. thanks!
The CQ bit was checked by victorhsieh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907593003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by victorhsieh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907593003/1
Message was sent while issue was closed.
Description was changed from ========== Fix build error when USE_OZONE is undefined Not sure this is correct behavior, but this should make the build green. BUG=b/27779397,574241 TEST=ninja ========== to ========== Fix build error when USE_OZONE is undefined Not sure this is correct behavior, but this should make the build green. BUG=b/27779397,574241 TEST=ninja ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix build error when USE_OZONE is undefined Not sure this is correct behavior, but this should make the build green. BUG=b/27779397,574241 TEST=ninja ========== to ========== Fix build error when USE_OZONE is undefined Not sure this is correct behavior, but this should make the build green. BUG=b/27779397,574241 TEST=ninja Committed: https://crrev.com/a586e644f9670115bda03981e931d91defb1a607 Cr-Commit-Position: refs/heads/master@{#388627} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a586e644f9670115bda03981e931d91defb1a607 Cr-Commit-Position: refs/heads/master@{#388627} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
