Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1907563002: Inline CFX_WideString::c_str. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Inline CFX_WideString::c_str. This was causing issues at one point with the GN build but seems to have been resolved in the meantime. Committed: https://pdfium.googlesource.com/pdfium/+/eca0f82e5c7bc7b7d34eaa32c452147ee2b7bbdb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M core/fxcrt/fx_basic_wstring.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M core/fxcrt/include/fx_string.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-20 18:47:23 UTC) #2
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-20 18:59:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907563002/1
4 years, 8 months ago (2016-04-20 19:00:37 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 19:03:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/eca0f82e5c7bc7b7d34eaa32c452147ee2b7...

Powered by Google App Engine
This is Rietveld 408576698