Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: runtime/vm/scopes.h

Issue 190753004: - Ensure that all names in local scopes are symbols. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/scopes.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/scopes.h
===================================================================
--- runtime/vm/scopes.h (revision 33439)
+++ runtime/vm/scopes.h (working copy)
@@ -35,6 +35,7 @@
index_(LocalVariable::kUninitializedIndex) {
ASSERT(type.IsZoneHandle());
ASSERT(type.IsFinalized());
+ ASSERT(name.IsSymbol());
}
intptr_t token_pos() const { return token_pos_; }
@@ -122,6 +123,7 @@
NameReference(intptr_t token_pos, const String& name)
: token_pos_(token_pos),
name_(name) {
+ ASSERT(name.IsSymbol());
}
const String& name() const { return name_; }
intptr_t token_pos() const { return token_pos_; }
@@ -151,6 +153,7 @@
name_(name),
owner_(NULL),
kind_(kind) {
+ ASSERT(name.IsSymbol());
}
static SourceLabel* New(intptr_t token_pos, String* name, Kind kind) {
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698