- Ensure that all names in local scopes are symbols.

runtime/vm/scopes.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_SCOPES_H_
 #define VM_SCOPES_H_
 
 #include "platform/assert.h"
 #include "platform/globals.h"
 #include "vm/allocation.h"
@@ skipping 17 matching lines @@
       name_(name),
       owner_(NULL),
       type_(type),
       const_value_(NULL),
       is_final_(false),
       is_captured_(false),
       is_invisible_(false),
       index_(LocalVariable::kUninitializedIndex) {
     ASSERT(type.IsZoneHandle());
     ASSERT(type.IsFinalized());
+    ASSERT(name.IsSymbol());
   }
 
   intptr_t token_pos() const { return token_pos_; }
   const String& name() const { return name_; }
   LocalScope* owner() const { return owner_; }
   void set_owner(LocalScope* owner) {
     ASSERT(owner_ == NULL);
     owner_ = owner;
   }
 
@@ skipping 67 matching lines @@
   friend class LocalScope;
   DISALLOW_COPY_AND_ASSIGN(LocalVariable);
 };
 
 
 class NameReference : public ZoneAllocated {
  public:
   NameReference(intptr_t token_pos, const String& name)
     : token_pos_(token_pos),
       name_(name) {
+    ASSERT(name.IsSymbol());
   }
   const String& name() const { return name_; }
   intptr_t token_pos() const { return token_pos_; }
   void set_token_pos(intptr_t value) { token_pos_ = value; }
  private:
   intptr_t token_pos_;
   const String& name_;
 };
 
 
 class SourceLabel : public ZoneAllocated {
  public:
   enum Kind {
     kFor,
     kWhile,
     kDoWhile,
     kSwitch,
     kCase,
     kTry,
     kCatch,
     kForward,
     kStatement  // Any statement other than the above
   };
 
   SourceLabel(intptr_t token_pos, const String& name, Kind kind)
     : token_pos_(token_pos),
       name_(name),
       owner_(NULL),
       kind_(kind) {
+    ASSERT(name.IsSymbol());
   }
 
   static SourceLabel* New(intptr_t token_pos, String* name, Kind kind) {
     if (name != NULL) {
       return new SourceLabel(token_pos, *name, kind);
     } else {
       return new SourceLabel(token_pos,
                              Symbols::DefaultLabel(),
                              kind);
     }
@@ skipping 189 matching lines @@
   // List of names referenced in this scope and its children that
   // are not resolved to local variables.
   GrowableArray<NameReference*> referenced_;
 
   DISALLOW_COPY_AND_ASSIGN(LocalScope);
 };
 
 }  // namespace dart
 
 #endif  // VM_SCOPES_H_