Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 1907503002: Prevent to measure the whole word when break-word (Closed)

Created:
4 years, 8 months ago by kojii
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Prevent to measure the whole word when break-word crrev.com/385693 changed the line breaker to measure word-by-word then rewind if break-word/break-all. This causes a performance regression when a word is extraordinary long, such as minified JS/CSS or hex/base64 data. This patch fixes to measure character-by-character, but unlike before r385693, it lets overflow by 2em then rewind to the correct position. This prevents the line breaker to measure the whole word, while still measuring ligatures/kernings correctly as long as the sum of such effects is within 2em. BUG=603398 Review URL: https://codereview.chromium.org/1900513002 Cr-Commit-Position: refs/heads/master@{#387974} (cherry picked from commit 41fe145a8629f1f7002b41a8e12687b97d5e635f) Committed: https://chromium.googlesource.com/chromium/src/+/7183255cb9dd01ff20a267c2b682d92feb6ad2a1

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
kojii
4 years, 8 months ago (2016-04-20 15:14:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7183255cb9dd01ff20a267c2b682d92feb6ad2a1.

Powered by Google App Engine
This is Rietveld 408576698