Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 19075002: cc: layer_or_descendant_has_copy_request is inherited by siblings. (Closed)

Created:
7 years, 5 months ago by danakj
Modified:
7 years, 5 months ago
Reviewers:
enne (OOO), piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

cc: layer_or_descendant_has_copy_request is inherited by siblings. If a layer has this value to be true, it should not be also set on siblings that follow it. Tests: LayerTreeHostCommonTest.SubtreeHiddenWithCopyRequest R=enne, piman BUG=242572 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211487

Patch Set 1 #

Total comments: 2

Patch Set 2 : copy-output-request-sibling-inherits: templatez #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -9 lines) Patch
M cc/trees/layer_tree_host_common.cc View 1 5 chunks +16 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 3 chunks +41 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
7 years, 5 months ago (2013-07-11 23:13:54 UTC) #1
piman
lgtm https://codereview.chromium.org/19075002/diff/1/cc/trees/layer_tree_host_common.cc File cc/trees/layer_tree_host_common.cc (right): https://codereview.chromium.org/19075002/diff/1/cc/trees/layer_tree_host_common.cc#newcode807 cc/trees/layer_tree_host_common.cc:807: PreCalculateMetaInformation<LayerType>(child_layer, &data_for_child); nit: no need for <LayerType> since ...
7 years, 5 months ago (2013-07-11 23:18:25 UTC) #2
danakj
https://codereview.chromium.org/19075002/diff/1/cc/trees/layer_tree_host_common.cc File cc/trees/layer_tree_host_common.cc (right): https://codereview.chromium.org/19075002/diff/1/cc/trees/layer_tree_host_common.cc#newcode807 cc/trees/layer_tree_host_common.cc:807: PreCalculateMetaInformation<LayerType>(child_layer, &data_for_child); On 2013/07/11 23:18:25, piman wrote: > nit: ...
7 years, 5 months ago (2013-07-12 18:48:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/19075002/10001
7 years, 5 months ago (2013-07-12 18:48:19 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-12 23:46:04 UTC) #5
Message was sent while issue was closed.
Change committed as 211487

Powered by Google App Engine
This is Rietveld 408576698