Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1907493003: [Android] Log raw output for instrumentation test failures at info level. (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Log raw output for instrumentation test failures at info level. BUG=605172 Committed: https://crrev.com/25c8be0dd097710e6a0986fa88904565c8b55a3b Cr-Commit-Position: refs/heads/master@{#388682}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -20 lines) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +0 lines, -5 lines 0 comments Download
M build/android/pylib/local/device/local_device_environment.py View 2 chunks +13 lines, -8 lines 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 2 chunks +15 lines, -6 lines 2 comments Download

Messages

Total messages: 17 (7 generated)
jbudorick
4 years, 8 months ago (2016-04-20 22:31:23 UTC) #2
mikecase (-- gone --)
lgtm https://codereview.chromium.org/1907493003/diff/1/build/android/pylib/local/device/local_device_instrumentation_test_run.py File build/android/pylib/local/device/local_device_instrumentation_test_run.py (right): https://codereview.chromium.org/1907493003/diff/1/build/android/pylib/local/device/local_device_instrumentation_test_run.py#newcode248 build/android/pylib/local/device/local_device_instrumentation_test_run.py:248: # TODO(jbudorick): Make instrumentation tests output a JSON ...
4 years, 8 months ago (2016-04-20 22:50:32 UTC) #3
jbudorick
https://codereview.chromium.org/1907493003/diff/1/build/android/pylib/local/device/local_device_instrumentation_test_run.py File build/android/pylib/local/device/local_device_instrumentation_test_run.py (right): https://codereview.chromium.org/1907493003/diff/1/build/android/pylib/local/device/local_device_instrumentation_test_run.py#newcode248 build/android/pylib/local/device/local_device_instrumentation_test_run.py:248: # TODO(jbudorick): Make instrumentation tests output a JSON so ...
4 years, 8 months ago (2016-04-20 22:54:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907493003/1
4 years, 8 months ago (2016-04-20 22:55:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/135839)
4 years, 8 months ago (2016-04-20 23:16:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907493003/1
4 years, 8 months ago (2016-04-20 23:17:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/216003)
4 years, 8 months ago (2016-04-20 23:39:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907493003/1
4 years, 8 months ago (2016-04-21 01:22:47 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 03:13:37 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:31:10 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25c8be0dd097710e6a0986fa88904565c8b55a3b
Cr-Commit-Position: refs/heads/master@{#388682}

Powered by Google App Engine
This is Rietveld 408576698