Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1907463002:
Disable rasterize_and_record_micro.top_25_smooth on Linux and Android (Closed)
|
Created:
4 years, 8 months ago by petrcermak Modified:
4 years, 8 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable rasterize_and_record_micro.top_25_smooth on Linux and Android
Rationale: The benchmark is causing persistent redness on one Linux and
several Android perf bots:
https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%20(2)
TBR=skyostil
BUG=600377, 605120
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
Committed: https://crrev.com/502afb658d9b946b123ced6d0c91c444adb23f19
Cr-Commit-Position: refs/heads/master@{#388528}
Patch Set 1 #Patch Set 2 : Disable on Android as well #Messages
Total messages: 21 (12 generated)
Description was changed from ========== Disable rasterize_and_record_micro.top_25_smooth on Linux Rationale: The benchmark is causing persistent redness on the "Linux Perf (5)" bot: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5) TBR=skyostil BUG=600377 ========== to ========== Disable rasterize_and_record_micro.top_25_smooth on Linux Rationale: The benchmark is causing persistent redness on the "Linux Perf (5)" bot: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5) TBR=skyostil BUG=600377 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
PTAL. Thanks, Petr
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907463002/1
skyostil@chromium.org changed reviewers: + skyostil@chromium.org
lgtm.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
Looks like I'll have to disable the benchmark on both Linux and Android :-\
Description was changed from ========== Disable rasterize_and_record_micro.top_25_smooth on Linux Rationale: The benchmark is causing persistent redness on the "Linux Perf (5)" bot: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5) TBR=skyostil BUG=600377 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Disable rasterize_and_record_micro.top_25_smooth on Linux and Android Rationale: The benchmark is causing persistent redness on one Linux and several Android perf bots: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... TBR=skyostil BUG=600377 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
The CQ bit was checked by petrcermak@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/1907463002/#ps20001 (title: "Disable on Android as well")
The CQ bit was unchecked by petrcermak@chromium.org
Description was changed from ========== Disable rasterize_and_record_micro.top_25_smooth on Linux and Android Rationale: The benchmark is causing persistent redness on one Linux and several Android perf bots: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... TBR=skyostil BUG=600377 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Disable rasterize_and_record_micro.top_25_smooth on Linux and Android Rationale: The benchmark is causing persistent redness on one Linux and several Android perf bots: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... TBR=skyostil BUG=600377,605120 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907463002/20001
Message was sent while issue was closed.
Description was changed from ========== Disable rasterize_and_record_micro.top_25_smooth on Linux and Android Rationale: The benchmark is causing persistent redness on one Linux and several Android perf bots: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... TBR=skyostil BUG=600377,605120 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Disable rasterize_and_record_micro.top_25_smooth on Linux and Android Rationale: The benchmark is causing persistent redness on one Linux and several Android perf bots: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... TBR=skyostil BUG=600377,605120 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1903903003/ by skyostil@chromium.org. The reason for reverting is: Benchmark fixed with https://codereview.chromium.org/1898813002..
Message was sent while issue was closed.
Description was changed from ========== Disable rasterize_and_record_micro.top_25_smooth on Linux and Android Rationale: The benchmark is causing persistent redness on one Linux and several Android perf bots: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... TBR=skyostil BUG=600377,605120 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Disable rasterize_and_record_micro.top_25_smooth on Linux and Android Rationale: The benchmark is causing persistent redness on one Linux and several Android perf bots: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(5) https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2... TBR=skyostil BUG=600377,605120 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/502afb658d9b946b123ced6d0c91c444adb23f19 Cr-Commit-Position: refs/heads/master@{#388528} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/502afb658d9b946b123ced6d0c91c444adb23f19 Cr-Commit-Position: refs/heads/master@{#388528} |
